[GitHub] [incubator-doris] morningman commented on a change in pull request #2902: bitmap_union_count support window function

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2902: bitmap_union_count support window function
URL: https://github.com/apache/incubator-doris/pull/2902#discussion_r379903105
 
 

 ##########
 File path: be/src/exprs/bitmap_function.h
 ##########
 @@ -46,6 +46,9 @@ class BitmapFunctions {
     // the input src's ptr need to point a BitmapValue, this function will release the
     // BitmapValue memory
     static BigIntVal bitmap_finalize(FunctionContext* ctx, const StringVal& src);
+    // Get the bitmap cardinality, the difference from bitmap_finalize method is
+    // bitmap_get_value method doesn't free memory
+    static BigIntVal bitmap_get_value(FunctionContext* ctx, const StringVal& src);
 
 Review comment:
   How about `bitmap_get_cardinality` ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org