You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/27 02:20:01 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #7329: Added ability to delete and update records in ElasticSearch sink connector

codelipenghui commented on a change in pull request #7329:
URL: https://github.com/apache/pulsar/pull/7329#discussion_r446472667



##########
File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchSink.java
##########
@@ -66,6 +69,11 @@
     private CredentialsProvider credentialsProvider;
     private ElasticSearchConfig elasticSearchConfig;
 
+    protected static final String ACTION = "ACTION";

Review comment:
       It's better to add a prefix for the property name e.g. (ELASTCSEARCH_ACTION).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org