You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/30 09:43:20 UTC

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #5005: Replace TableMetaData in sharding-scaling-module

KomachiSion opened a new pull request #5005: Replace TableMetaData in sharding-scaling-module
URL: https://github.com/apache/incubator-shardingsphere/pull/5005
 
 
   Fixes #4866 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5005: Replace TableMetaData in sharding-scaling-module

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #5005: Replace TableMetaData in sharding-scaling-module
URL: https://github.com/apache/incubator-shardingsphere/pull/5005#issuecomment-605919696
 
 
   ## Pull Request Test Coverage Report for [Build 10704](https://coveralls.io/builds/29705476)
   
   * **25** of **33**   **(75.76%)**  changed or added relevant lines in **9** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.2%**) to **57.331%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptColumnMetaData.java](https://coveralls.io/builds/29705476/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptColumnMetaData.java#L41) | 0 | 1 | 0.0%
   | [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptTableMetaDataDecorator.java](https://coveralls.io/builds/29705476/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptTableMetaDataDecorator.java#L57) | 0 | 1 | 0.0%
   | [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/wal/WalEventConverter.java](https://coveralls.io/builds/29705476/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2Fwal%2FWalEventConverter.java#L127) | 0 | 1 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingTableMetaDataDecorator.java](https://coveralls.io/builds/29705476/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingTableMetaDataDecorator.java#L53) | 0 | 2 | 0.0%
   | [sharding-scaling/sharding-scaling-mysql/src/main/java/org/apache/shardingsphere/shardingscaling/mysql/MySQLBinlogReader.java](https://coveralls.io/builds/29705476/source?filename=sharding-scaling%2Fsharding-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fmysql%2FMySQLBinlogReader.java#L117) | 0 | 3 | 0.0%
   <!-- | **Total:** | **25** | **33** | **75.76%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29705476/badge)](https://coveralls.io/builds/29705476) |
   | :-- | --: |
   | Change from base [Build 10702](https://coveralls.io/builds/29702082): |  0.2% |
   | Covered Lines: | 11738 |
   | Relevant Lines: | 20474 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5005: Replace TableMetaData in sharding-scaling-module

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #5005: Replace TableMetaData in sharding-scaling-module
URL: https://github.com/apache/incubator-shardingsphere/pull/5005#issuecomment-605917214
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr&el=h1) Report
   > Merging [#5005](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/8887a699636309994883a676e8c912dd8728a17d&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `75.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5005      +/-   ##
   ============================================
   + Coverage     53.77%   53.82%   +0.05%     
   + Complexity      442      441       -1     
   ============================================
     Files          1143     1139       -4     
     Lines         20488    20474      -14     
     Branches       3749     3741       -8     
   ============================================
   + Hits          11017    11021       +4     
   + Misses         8770     8748      -22     
   - Partials        701      705       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...sphere/encrypt/metadata/EncryptColumnMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdENvbHVtbk1ldGFEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ncrypt/metadata/EncryptTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdFRhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/execute/executor/reader/AbstractJDBCReader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2V4ZWN1dGUvZXhlY3V0b3IvcmVhZGVyL0Fic3RyYWN0SkRCQ1JlYWRlci5qYXZh) | `83.33% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...phere/shardingscaling/mysql/MySQLBinlogReader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvTXlTUUxCaW5sb2dSZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rdingscaling/postgresql/wal/WalEventConverter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9wb3N0Z3Jlc3FsL3dhbC9XYWxFdmVudENvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...shardingscaling/core/metadata/MetaDataManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL01ldGFEYXRhTWFuYWdlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ore/synctask/history/HistoryDataSyncTaskGroup.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3N5bmN0YXNrL2hpc3RvcnkvSGlzdG9yeURhdGFTeW5jVGFza0dyb3VwLmphdmE=) | `76.69% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `68.08% <100.00%> (+68.08%)` | `0.00 <0.00> (ø)` | |
   | [...ql/parser/binder/metadata/table/TableMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvdGFibGUvVGFibGVNZXRhRGF0YS5qYXZh) | `89.28% <100.00%> (+10.71%)` | `0.00 <0.00> (ø)` | |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr&el=footer). Last update [8887a69...026ef43](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5005: Replace TableMetaData in sharding-scaling-module

Posted by GitBox <gi...@apache.org>.

terrymanu merged pull request #5005: Replace TableMetaData in sharding-scaling-module
URL: https://github.com/apache/incubator-shardingsphere/pull/5005
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services