You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/03 15:48:44 UTC
[kudu-CR] [build] CMake fixes for Apple ARM builds
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16816
Change subject: [build] CMake fixes for Apple ARM builds
......................................................................
[build] CMake fixes for Apple ARM builds
This patch includes some small tweaks for CMake when building Kudu on
Apple ARM architectures. It also includes some logging to help debug an
issues in the future.
Change-Id: Ifad9a4d272e6d720ac006da313f53490cfd47a9c
---
M CMakeLists.txt
M src/kudu/gutil/CMakeLists.txt
2 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/16816/1
--
To view, visit http://gerrit.cloudera.org:8080/16816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifad9a4d272e6d720ac006da313f53490cfd47a9c
Gerrit-Change-Number: 16816
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] CMake fixes for Apple ARM builds
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16816 )
Change subject: [build] CMake fixes for Apple ARM builds
......................................................................
Patch Set 1: Code-Review+2
I don't have an M1 chip handy, but I built on Catalina 10.15.7, CentOS 7.3.1611, and CentOS 6.6 and nothing broke.
--
To view, visit http://gerrit.cloudera.org:8080/16816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad9a4d272e6d720ac006da313f53490cfd47a9c
Gerrit-Change-Number: 16816
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Dec 2020 20:30:10 +0000
Gerrit-HasComments: No
[kudu-CR] [build] CMake fixes for Apple ARM builds
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16816 )
Change subject: [build] CMake fixes for Apple ARM builds
......................................................................
[build] CMake fixes for Apple ARM builds
This patch includes some small tweaks for CMake when building Kudu on
Apple ARM architectures. It also includes some logging to help debug an
issues in the future.
Change-Id: Ifad9a4d272e6d720ac006da313f53490cfd47a9c
Reviewed-on: http://gerrit.cloudera.org:8080/16816
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M CMakeLists.txt
M src/kudu/gutil/CMakeLists.txt
2 files changed, 13 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifad9a4d272e6d720ac006da313f53490cfd47a9c
Gerrit-Change-Number: 16816
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)