You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@htrace.apache.org by Konstantin Gribov <gr...@gmail.com> on 2017/03/06 12:26:22 UTC
[DISCUSS] OpenTracing API implementation
Hi, folks.
Are you interested in OpenTracing API (OT) implementation with HTrace as
tracer target?
As I saw in [1] there was a bit of interest for OT but from different angle
(community-wise).
Zipkin has both it's own Dapper-inpired API and OT API impl which gives
good way for API to be vendor neutral. Also Uber is opensourcing its Jaeger
(which is native OT impl).
I think, implementing OT API as separate module could bring more users to
HTrace and improve its adaption.
If PMC is interested in it, I could give it a try.
[1]:
https://lists.apache.org/thread.html/373c91d58dcb9c87e29ff4cb2ad4d339ec228fdf6155b2e6a09c23f6@1463677907@%3Cdev.htrace.apache.org%3E
--
Best regards,
Konstantin Gribov
Re: [DISCUSS] OpenTracing API implementation
Posted by Adrian Cole <ad...@gmail.com>.
> If nobody steps up to implement it before me or working on it yet, I'll try
> to get my hands into it. Unfortunately I'm not sure when I'd have spare
> time for it.
There will be some work needed in htrace as the OT interface is wider
in most places, but not precise in others. It should be easier than
zipkin, since htrace has a single span per tracer model. That said
there are some key concerns which may or may not play out well,
particularly htrace's lack of a trace ID.
For example, you'll have choices to make on how to handle nested data
structures that are sent via its "log" api. Also, if or how to map
"special" properties defined in opentracing such as "span.kind". How
to deal with the required propagation apis (for example, how to encode
and decode a trace context in binary and text form). Sadly, there's no
compatibility kit or interop tests of any kind, so figuring out if
things work will largely be up to testers.
Anyway, in case it helps, here are a couple bridge projects:
https://github.com/openzipkin/brave-opentracing
https://github.com/DealerDotCom/sleuth-opentracing
> I had two things in mind starting this discussion:
> - check that nobody is working on it yet (to avoid wasting time if someone
> is);
pretty confident you are it.
> - check that such work would be useful for someone else.
this is an important step! There's certainly work to do, and best to
not go at it without at least a user to help q/a. I'd ping their
gitter and/or use twitter to recruit others interested if I were you.
> I haven't checked with IPMC and legal but opentracing seems to be under
> Apache License v2.0 and has no externtal deps, so it should be ok as
> external dependency.
agreed, though bear in mind OT java at least is <1.0, so you'd need to
plan for how to manage version updates (since htrace is more coarse
grained at >1.0.
Good luck on your journey!
Re: [DISCUSS] OpenTracing API implementation
Posted by Konstantin Gribov <gr...@gmail.com>.
Colin,
it's exaclty what I'm proposing ,)
If nobody steps up to implement it before me or working on it yet, I'll try
to get my hands into it. Unfortunately I'm not sure when I'd have spare
time for it.
I had two things in mind starting this discussion:
- check that nobody is working on it yet (to avoid wasting time if someone
is);
- check that such work would be useful for someone else.
I haven't checked with IPMC and legal but opentracing seems to be under
Apache License v2.0 and has no externtal deps, so it should be ok as
external dependency.
пн, 6 мар. 2017 г. в 21:32, Colin McCabe <cm...@apache.org>:
> Hi Konstantin,
>
> Just to be clear, you're proposing an adapter that allows people to use
> OpenTracing as the span creation API, and HTrace SpanReceivers to store
> spans? That seems like an interesting idea and I don't think anyone
> would object to adding it. It's just a matter of someone committing to
> write and maintain it.
>
> best,
> Colin
>
>
> On Mon, Mar 6, 2017, at 04:26, Konstantin Gribov wrote:
> > Hi, folks.
> >
> > Are you interested in OpenTracing API (OT) implementation with HTrace as
> > tracer target?
> >
> > As I saw in [1] there was a bit of interest for OT but from different
> > angle
> > (community-wise).
> >
> > Zipkin has both it's own Dapper-inpired API and OT API impl which gives
> > good way for API to be vendor neutral. Also Uber is opensourcing its
> > Jaeger
> > (which is native OT impl).
> >
> > I think, implementing OT API as separate module could bring more users to
> > HTrace and improve its adaption.
> >
> > If PMC is interested in it, I could give it a try.
> >
> > [1]:
> >
> https://lists.apache.org/thread.html/373c91d58dcb9c87e29ff4cb2ad4d339ec228fdf6155b2e6a09c23f6@1463677907@%3Cdev.htrace.apache.org%3E
> >
> > --
> >
> > Best regards,
> > Konstantin Gribov
>
--
Best regards,
Konstantin Gribov
Re: [DISCUSS] OpenTracing API implementation
Posted by Stack <st...@duboce.net>.
What Colin said.
S
On Mon, Mar 6, 2017 at 10:32 AM, Colin McCabe <cm...@apache.org> wrote:
> Hi Konstantin,
>
> Just to be clear, you're proposing an adapter that allows people to use
> OpenTracing as the span creation API, and HTrace SpanReceivers to store
> spans? That seems like an interesting idea and I don't think anyone
> would object to adding it. It's just a matter of someone committing to
> write and maintain it.
>
> best,
> Colin
>
>
> On Mon, Mar 6, 2017, at 04:26, Konstantin Gribov wrote:
> > Hi, folks.
> >
> > Are you interested in OpenTracing API (OT) implementation with HTrace as
> > tracer target?
> >
> > As I saw in [1] there was a bit of interest for OT but from different
> > angle
> > (community-wise).
> >
> > Zipkin has both it's own Dapper-inpired API and OT API impl which gives
> > good way for API to be vendor neutral. Also Uber is opensourcing its
> > Jaeger
> > (which is native OT impl).
> >
> > I think, implementing OT API as separate module could bring more users to
> > HTrace and improve its adaption.
> >
> > If PMC is interested in it, I could give it a try.
> >
> > [1]:
> > https://lists.apache.org/thread.html/373c91d58dcb9c87e29ff4cb2ad4d3
> 39ec228fdf6155b2e6a09c23f6@1463677907@%3Cdev.htrace.apache.org%3E
> >
> > --
> >
> > Best regards,
> > Konstantin Gribov
>
Re: [DISCUSS] OpenTracing API implementation
Posted by Colin McCabe <cm...@apache.org>.
Hi Konstantin,
Just to be clear, you're proposing an adapter that allows people to use
OpenTracing as the span creation API, and HTrace SpanReceivers to store
spans? That seems like an interesting idea and I don't think anyone
would object to adding it. It's just a matter of someone committing to
write and maintain it.
best,
Colin
On Mon, Mar 6, 2017, at 04:26, Konstantin Gribov wrote:
> Hi, folks.
>
> Are you interested in OpenTracing API (OT) implementation with HTrace as
> tracer target?
>
> As I saw in [1] there was a bit of interest for OT but from different
> angle
> (community-wise).
>
> Zipkin has both it's own Dapper-inpired API and OT API impl which gives
> good way for API to be vendor neutral. Also Uber is opensourcing its
> Jaeger
> (which is native OT impl).
>
> I think, implementing OT API as separate module could bring more users to
> HTrace and improve its adaption.
>
> If PMC is interested in it, I could give it a try.
>
> [1]:
> https://lists.apache.org/thread.html/373c91d58dcb9c87e29ff4cb2ad4d339ec228fdf6155b2e6a09c23f6@1463677907@%3Cdev.htrace.apache.org%3E
>
> --
>
> Best regards,
> Konstantin Gribov