You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by André Malo <nd...@perlig.de> on 2005/10/28 19:43:37 UTC

[PATCH] [python-bindings] make svn.core reload-safe

Hi,

If one reloads svn.core (I'm doing this for my unit tests), the atexit pool 
destruction handler may crash, because _core may be already None or 
application_pool may be None or the pool may have been destroyed already. 
The attached patch fixes this.

[[[
* subversion/bindings/swig/python/svn/core.py
  (global): Fix atexit handler to destroy application_pool only once and to
  not depend on the existance of the _core import.
]]]

It would be nice, if this could make it into the final 1.3 release.

nd
-- 
> Rätselnd, was ein Anthroposoph mit Unterwerfung zu tun hat...
                    ^^^^^^^^^^^^
[...] Dieses Wort gibt so viele Stellen für einen Spelling Flame her, und
Du gönnst einem keine einzige.    -- Jean Claude und David Kastrup in dtl

Re: [PATCH] [python-bindings] make svn.core reload-safe

Posted by Daniel Rall <dl...@collab.net>.
On Fri, 28 Oct 2005, David James wrote:
...
> > It would be nice, if this could make it into the final 1.3 release.
> Andre, thanks for your patch! I've applied it with a few tweaks in
> r17082 and proposed it for backport to the 1.3.x branch.

It's in the 1.3.x branch now.
-- 

Daniel Rall

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] [python-bindings] make svn.core reload-safe

Posted by David James <ja...@gmail.com>.
On 10/28/05, André Malo <nd...@perlig.de> wrote:
> Hi,
>
> If one reloads svn.core (I'm doing this for my unit tests), the atexit pool
> destruction handler may crash, because _core may be already None or
> application_pool may be None or the pool may have been destroyed already.
> The attached patch fixes this.
>
> [[[
> * subversion/bindings/swig/python/svn/core.py
>   (global): Fix atexit handler to destroy application_pool only once and to
>   not depend on the existance of the _core import.
> ]]]
>
> It would be nice, if this could make it into the final 1.3 release.
Andre, thanks for your patch! I've applied it with a few tweaks in
r17082 and proposed it for backport to the 1.3.x branch.

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james