[GitHub] [incubator-superset] kristw commented on a change in pull request #10790: refactor: merge/upgrade superset-ui packages

[GitBox <gi...@apache.org>]

kristw commented on a change in pull request #10790:
URL: https://github.com/apache/incubator-superset/pull/10790#discussion_r485864568



##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -16,19 +16,19 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import airbnb from '@superset-ui/color/esm/colorSchemes/categorical/airbnb';
-import categoricalD3 from '@superset-ui/color/esm/colorSchemes/categorical/d3';
-import echarts from '@superset-ui/color/esm/colorSchemes/categorical/echarts';
-import google from '@superset-ui/color/esm/colorSchemes/categorical/google';
-import lyft from '@superset-ui/color/esm/colorSchemes/categorical/lyft';
-import preset from '@superset-ui/color/esm/colorSchemes/categorical/preset';
-import sequentialCommon from '@superset-ui/color/esm/colorSchemes/sequential/common';
-import sequentialD3 from '@superset-ui/color/esm/colorSchemes/sequential/d3';
+import airbnb from '@superset-ui/core/esm/color/colorSchemes/categorical/airbnb';
+import categoricalD3 from '@superset-ui/core/esm/color/colorSchemes/categorical/d3';
+import echarts from '@superset-ui/core/esm/color/colorSchemes/categorical/echarts';
+import google from '@superset-ui/core/esm/color/colorSchemes/categorical/google';
+import lyft from '@superset-ui/core/esm/color/colorSchemes/categorical/lyft';
+import preset from '@superset-ui/core/esm/color/colorSchemes/categorical/preset';
+import sequentialCommon from '@superset-ui/core/esm/color/colorSchemes/sequential/common';
+import sequentialD3 from '@superset-ui/core/esm/color/colorSchemes/sequential/d3';

Review comment:
       we could also add the export from index and get rid of deep import later.
   Agree not doing it in this humongous PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org