You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/08/07 00:59:32 UTC
[GitHub] [lucene] gsmiller opened a new pull request #236: LUCENE-10046: Fix counting bug in StringValueFacetCounts
gsmiller opened a new pull request #236:
URL: https://github.com/apache/lucene/pull/236
# Description
Fixes a counting bug in `StringValueFacetCounts` exposed on a specific execution path.
# Solution
Make sure to map to a global ordinal as necessary.
# Tests
Added a new test case to expose the issue.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #236: LUCENE-10046: Fix counting bug in StringValueFacetCounts
Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #236:
URL: https://github.com/apache/lucene/pull/236#issuecomment-894662487
Pushing this fix without a review since as it's a simple change and kind of a nasty edge-case bug. Happy to iterate on this / incorporate feedback post-push if anyone has thought though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller merged pull request #236: LUCENE-10046: Fix counting bug in StringValueFacetCounts
Posted by GitBox <gi...@apache.org>.
gsmiller merged pull request #236:
URL: https://github.com/apache/lucene/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org