You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/05 11:13:02 UTC
[GitHub] [incubator-doris] zuochunwei opened a new pull request #7024: fix core problem: use object replace pointer
zuochunwei opened a new pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024
old version:
NodeChannel::_node_info is a pointer member data， this member pointer is set by _parent->_nodes_info->find_node in the function NodeChannel::init(), _parent->_nodes_info is managed by object_pool, the object_pool‘ lifetime is the same with PlanFragmentExecutor.
but _node_info will be used in _add_batch_closure' success handler, it's a async callback, in this callback, PlanFragmentExecutor created for other RPC may be destroy for some reasons, such as timeout or canceled, so continue use _node_info is wrong.
refactor: use NodeInfo _node_info replace NodeInfo *_node_info, just copy NodeInfo in init function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024#issuecomment-966164949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024#issuecomment-961841478
> Conflict
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024#issuecomment-961836375
Conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024#issuecomment-962578999
> > Conflict
>
> done
Unit test compile failed. You need to run `run-be-ut.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024#issuecomment-961841478
> Conflict
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024#issuecomment-961836375
Conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024#issuecomment-961841478
> Conflict
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7024: fix core problem: use object replace pointer
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024#issuecomment-961836375
Conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org