You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/07/26 07:27:04 UTC
[Impala-ASF-CR] IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
yx91490@126.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18722
Change subject: IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
......................................................................
IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
Similar to IMPALA-11332, The current VerticalOutputFormatter is
stripping trailing whitespaces from the last line of output. This
rstrip() was intended to remove an extra newline,
but it is matching other white space. This is a
problem for a SQL query like:
select 'Trailing whitespace ';
This changes the rstrip() to rstrip('\n') to
avoid removing the other white space.
Testing:
- Current shell tests pass
- Added a shell test that verifies trailing whitespace
is not being stripped.
Change-Id: Id66162d28498e7bef2933651616cf3df2fb0f354
---
M shell/shell_output.py
M tests/shell/test_shell_commandline.py
2 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/18722/4
--
To view, visit http://gerrit.cloudera.org:8080/18722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id66162d28498e7bef2933651616cf3df2fb0f354
Gerrit-Change-Number: 18722
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18722 )
Change subject: IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
......................................................................
IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
Similar to IMPALA-11332, The current VerticalOutputFormatter is
stripping trailing whitespaces from the last line of output. This
rstrip() was intended to remove an extra newline,
but it is matching other white space. This is a
problem for a SQL query like:
select 'Trailing whitespace ';
This changes the rstrip() to rstrip('\n') to
avoid removing the other white space.
Testing:
- Current shell tests pass
- Added a shell test that verifies trailing whitespace
is not being stripped.
Change-Id: Id66162d28498e7bef2933651616cf3df2fb0f354
Reviewed-on: http://gerrit.cloudera.org:8080/18722
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M shell/shell_output.py
M tests/shell/test_shell_commandline.py
2 files changed, 12 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id66162d28498e7bef2933651616cf3df2fb0f354
Gerrit-Change-Number: 18722
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18722 )
Change subject: IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id66162d28498e7bef2933651616cf3df2fb0f354
Gerrit-Change-Number: 18722
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 04:23:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18722 )
Change subject: IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
......................................................................
Patch Set 4:
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/18722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id66162d28498e7bef2933651616cf3df2fb0f354
Gerrit-Change-Number: 18722
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 04:23:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18722 )
Change subject: IMPALA-11380: Fix trailing whitespace for VerticalOutputFormatter
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11039/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id66162d28498e7bef2933651616cf3df2fb0f354
Gerrit-Change-Number: 18722
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 07:47:20 +0000
Gerrit-HasComments: No