[GitHub] [superset] rusackas commented on a diff in pull request #19938: fix(chart & table): make to allow highlight in case of numeric column

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #19938:
URL: https://github.com/apache/superset/pull/19938#discussion_r864260615


##########
superset-frontend/plugins/plugin-chart-table/src/Styles.tsx:
##########
@@ -71,7 +71,7 @@ export default styled.div`
       cursor: pointer;
     }
     td.dt-is-filter:hover {
-      background-color: ${theme.colors.secondary.light4};
+      background-color: ${theme.colors.secondary.light4} !important;

Review Comment:
   Does the inline style need to set a background color at all? If so, can we switch it to use className / Emotion?
   
   ... or the other way around, worst case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org