You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "erisu (via GitHub)" <gi...@apache.org> on 2025/08/04 17:31:53 UTC
[PR] feat!: remove remove create plugin support [cordova-plugman]
erisu opened a new pull request, #166:
URL: https://github.com/apache/cordova-plugman/pull/166
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Motivation, Context & Description
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Resolves #118
Resolves #120
Resolves #121
Resolves #122
Resolves #125
The tickets above report various issues related to the plugin creation functionality and the associated `platform` feature, which is tied to plugin development.
This area appears to be buggy, has not been maintained since 2019, and lacks proper documentation. Given this, I believe it is appropriate to remove it in the next major release.
Additionally, the Cordova dev documentation had significantly improved the plugin creation guide which does not reference plugman.
Several suggestions from the referenced tickets include:
- Creating a dedicated plugin template repository.
- Providing a clear, up-to-date documentation for plugin creation (which exists on the website).
- Deprecating the current plugin creation feature entirely.
Since the website contains an up-to-date documentation for plugin creation, the goal of this PR is to removing the feature completely. The guide on the website would be its replacement.
### Testing
<!-- Please describe in detail how you tested your changes. -->
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat!: remove remove create plugin support [cordova-plugman]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #166:
URL: https://github.com/apache/cordova-plugman/pull/166#issuecomment-3151768717
## [Codecov](https://app.codecov.io/gh/apache/cordova-plugman/pull/166?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 63.63%. Comparing base ([`6b56211`](https://app.codecov.io/gh/apache/cordova-plugman/commit/6b56211a9e99d07ea9d48d04620311c9225aac92?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5ef5b32`](https://app.codecov.io/gh/apache/cordova-plugman/commit/5ef5b324c566c228656f53132b4e75162d8b1414?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 53.84% 63.63% +9.79%
==========================================
Files 4 4
Lines 78 66 -12
==========================================
Hits 42 42
+ Misses 36 24 -12
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-plugman/pull/166?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat!: remove create plugin support [cordova-plugman]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #166:
URL: https://github.com/apache/cordova-plugman/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org