You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2024/03/04 15:06:05 UTC

[PR] Remove references to very old versions of surefire and TestNG [maven-surefire]

elharo opened a new pull request, #723:
URL: https://github.com/apache/maven-surefire/pull/723

   TestNG 5 is circa 2010. Focus on what the current version does.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove references to very old versions of surefire and TestNG [maven-surefire]

Posted by "rmannibucau (via GitHub)" <gi...@apache.org>.
rmannibucau commented on PR #723:
URL: https://github.com/apache/maven-surefire/pull/723#issuecomment-1977142555

   @elharo currentTimeMillis (surefire1144.Test1#sleep), I think you should feel free to add some tolerance ~50ms in `assertThat( xmlTime, is(greaterThanOrEqualTo( 1.6f ) ) );` assertion, in particular for windows which is even more flacky than linux for this call


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove references to very old versions of surefire and TestNG [maven-surefire]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #723:
URL: https://github.com/apache/maven-surefire/pull/723#issuecomment-1977131173

   Not sure what this is about. Probably flaky but I'll take a look:
   
   
   2024-03-04T16:53:19.6293270Z [INFO] Results:
   2024-03-04T16:53:19.6293780Z [INFO] 
   2024-03-04T16:53:19.6294100Z [ERROR] Failures: 
   2024-03-04T16:53:19.6299420Z [ERROR]   Surefire1144XmlRunTimeIT.testXmlRunTime:52 
   2024-03-04T16:53:19.6300810Z Expected: is a value equal to or greater than <1.6F>
   2024-03-04T16:53:19.6301930Z      but: <1.599F> was less than <1.6F>
   2024-03-04T16:53:19.6302850Z [INFO] 
   2024-03-04T16:53:19.6303680Z [ERROR] Tests run: 1015, Failures: 1, Errors: 0, Skipped: 135
   2024-03-04T16:53:19.6304780Z [INFO] 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove references to very old versions of surefire and TestNG [maven-surefire]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #723:
URL: https://github.com/apache/maven-surefire/pull/723


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org