You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2012/07/15 17:23:49 UTC

Review Request: BOOKKEEPER-259: Create a topic manager using versioned write for leader election

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5964/
-----------------------------------------------------------

Review request for bookkeeper.


Description
-------

currently, ZkTopicManager use zookeeper ephemeral node to store the owner information of a topic. so the znode will disappear when the owner hub server is down, the leader election is quite simple based on this model.
but for most key-value storage, there is no similar concepts like ephemeral node, but just providing versioned writes. so it would be better to provide a topic manager using versioned writes.


This addresses bug BOOKKEEPER-259.
    https://issues.apache.org/jira/browse/BOOKKEEPER-259


Diffs
-----

  hedwig-protocol/src/main/java/org/apache/hedwig/exceptions/PubSubException.java 750471b 
  hedwig-protocol/src/main/java/org/apache/hedwig/protocol/PubSubProtocol.java 330441d 
  hedwig-protocol/src/main/protobuf/PubSubProtocol.proto d29cfe9 
  hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java cf52ae8 
  hedwig-server/src/main/java/org/apache/hedwig/server/meta/MetadataManagerFactory.java 21b4577 
  hedwig-server/src/main/java/org/apache/hedwig/server/meta/TopicOwnershipManager.java PRE-CREATION 
  hedwig-server/src/main/java/org/apache/hedwig/server/meta/ZkMetadataManagerFactory.java 8a850af 
  hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java b0e8e07 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubInfo.java PRE-CREATION 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubLoad.java PRE-CREATION 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubServerManager.java PRE-CREATION 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/MMTopicManager.java PRE-CREATION 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkHubServerManager.java PRE-CREATION 
  hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java f92101a 
  hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestMetadataManager.java 6ab704f 
  hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestMetadataManagerFactory.java 412e848 
  hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestHubInfo.java PRE-CREATION 
  hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestHubLoad.java PRE-CREATION 
  hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestMMTopicManager.java PRE-CREATION 
  hedwig-server/src/test/java/org/apache/hedwig/server/topics/TestZkTopicManager.java 8c7cbd2 

Diff: https://reviews.apache.org/r/5964/diff/


Testing
-------


Thanks,

Sijie Guo