You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/10 13:37:56 UTC

[GitHub] [tvm] tqchen opened a new pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

tqchen opened a new pull request #9486:
URL: https://github.com/apache/tvm/pull/9486


   CompilationConfig was merged in on the basis that it is an internal experimental
   structure that helps to group the target. Constructing the config should not
   emit messages for most cases. Change LOG(INFO) to DLOG(INFO)
   so users won't be overwhelmed by messages.
   
   There are a few warning cases that also changes to DLOG. Given CompilationConfig
   is still experimental, it would be better to respect the current default convention
   and not trigger warnings that indicate an non-experimental suggestion.
   Warnings can be updated according with the convention.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] mbs-octoml commented on pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on pull request #9486:
URL: https://github.com/apache/tvm/pull/9486#issuecomment-965513343


   sorry for the trouble -- i'll assume log messages are part of the api and not get so trigger happy.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9486:
URL: https://github.com/apache/tvm/pull/9486#issuecomment-965171236


   Fixes https://github.com/apache/tvm/issues/9487 cc @mbs-octoml @zxybazh @Lunderberg @csullivan @masahi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #9486:
URL: https://github.com/apache/tvm/pull/9486#issuecomment-965171926


   cc @junrushao1994 this needs to go into v0.8 release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] masahi commented on pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9486:
URL: https://github.com/apache/tvm/pull/9486#issuecomment-965690600


   cc @Mousius a weird CI error from `test_compile_tflite_module_with_external_codegen_cmsisnn` again...
   https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9486/2/pipeline
   
   Can you take a look at what's going on? Looks like https://github.com/apache/tvm/pull/9480 didn't fix the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] junrushao1994 commented on pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9486:
URL: https://github.com/apache/tvm/pull/9486#issuecomment-965906625


   The CI doesn't fail this time. Thanks for the quick fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] junrushao1994 commented on pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9486:
URL: https://github.com/apache/tvm/pull/9486#issuecomment-965532108


   Retriggered the CI upon failure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] junrushao1994 commented on pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9486:
URL: https://github.com/apache/tvm/pull/9486#issuecomment-965697344


   i just re-re-triggered the CI and let's see how it goes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] junrushao1994 merged pull request #9486: [HOTFIX][TARGET] Change LOG in compilation config to DLOG

Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9486:
URL: https://github.com/apache/tvm/pull/9486


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org