You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/23 23:02:07 UTC

[GitHub] [airflow] jedcunningham opened a new pull request #15511: Finish refactor of DAG resource name helper

jedcunningham opened a new pull request #15511:
URL: https://github.com/apache/airflow/pull/15511


   This finishes moving `prefixed_dag_id` into `airflow.security.permissions.resource_name_for_dag`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #15511: Finish refactor of DAG resource name helper

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15511:
URL: https://github.com/apache/airflow/pull/15511


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #15511: Finish refactor of DAG resource name helper

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15511:
URL: https://github.com/apache/airflow/pull/15511#issuecomment-827158280


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on a change in pull request #15511: Finish refactor of DAG resource name helper

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #15511:
URL: https://github.com/apache/airflow/pull/15511#discussion_r619534369



##########
File path: airflow/security/permissions.py
##########
@@ -63,8 +63,8 @@
 DAG_PERMS = {ACTION_CAN_READ, ACTION_CAN_EDIT}
 
 
-def permission_name_for_dag(dag_id):
-    """Returns the permission name for a DAG id."""
+def resource_name_for_dag(dag_id):

Review comment:
       This is the _right_ name for this, pretty sure. Input @jhtimmins?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jhtimmins commented on a change in pull request #15511: Finish refactor of DAG resource name helper

Posted by GitBox <gi...@apache.org>.
jhtimmins commented on a change in pull request #15511:
URL: https://github.com/apache/airflow/pull/15511#discussion_r621752887



##########
File path: airflow/security/permissions.py
##########
@@ -63,8 +63,8 @@
 DAG_PERMS = {ACTION_CAN_READ, ACTION_CAN_EDIT}
 
 
-def permission_name_for_dag(dag_id):
-    """Returns the permission name for a DAG id."""
+def resource_name_for_dag(dag_id):

Review comment:
       Missed this. Yup!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org