[GitHub] [incubator-pinot] dongxiaoman commented on a change in pull request #7064: Allow updating controller and broker helix hostname

[GitBox <gi...@apache.org>]

dongxiaoman commented on a change in pull request #7064:
URL: https://github.com/apache/incubator-pinot/pull/7064#discussion_r662784424



##########
File path: pinot-minion/src/main/java/org/apache/pinot/minion/BaseMinionStarter.java
##########
@@ -240,6 +240,16 @@ public String getStatusDescription() {
     LOGGER.info("Pinot minion started");
   }
 
+  private void updateInstanceConfigIfNeeded() {
+    InstanceConfig instanceConfig = HelixHelper.getInstanceConfig(_helixManager, _instanceId);
+    boolean updated = HelixHelper.updateHostnamePort(instanceConfig, _host, _port);
+    updated |= HelixHelper.addDefaultTags(instanceConfig,

Review comment:
       I thought about this but will the "short circuit" feature stop the function from calling in some cases? @Jackie-Jiang 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org