You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/08/24 15:01:06 UTC
[GitHub] zeppelin pull request #1358: [ZEPPELIN-1365] Error of Zeppelin Application i...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1358
[ZEPPELIN-1365] Error of Zeppelin Application in development mode.
### What is this PR for?
This PR fixes the bug of running application in development mode.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1365
### How should this be tested?
1. run zeppelin
2. run org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer in development mode.
(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html)
3. and run paragraph like screenshot.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1365
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1358.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1358
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1358
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1358
Looks great to me!
Merging to master if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1358: [ZEPPELIN-1365] Error of Zeppelin Application i...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1358
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1358
I think it's not an issue related with this PR but Helium itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@Leemoonsoo Sure, I merged in 0.6 since it was the fixed version in JIRA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@mikhaildubkov `dev` doesn't exists on 0.6.x so you should use `master` branch for this.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@Leemoonsoo Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@astroshim Yeah I did but still same :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@AhyoungRyu Thank you for reviewing!!
Did you clear your browser cache?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1358: [ZEPPELIN-1365] Error of Zeppelin Application i...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1358
[ZEPPELIN-1365] Error of Zeppelin Application in development mode.
### What is this PR for?
This PR fixes the bug of running application in development mode.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1365
### How should this be tested?
1. run zeppelin
2. run org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer in development mode.
(http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/development/writingzeppelinapplication.html)
3. and run paragraph like screenshot.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1365
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1358.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1358
----
commit 9f640e5f1863e9e5b113ba31a939535e450f075e
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-24T14:52:45Z
add argument check.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@astroshim You ping, I merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1358
Sorry maybe it's my mistake to set jira version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1358: [ZEPPELIN-1365] Error of Zeppelin Application i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1358
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1358
Thank you @corneadoug
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by mikhaildubkov <gi...@git.apache.org>.
Github user mikhaildubkov commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@astroshim ,
Once I checkout branch-0,6 I'm unable to build project due to compilation error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project zeppelin-interpreter: Compilation failure
[ERROR] /zeppelin/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[35,43] package org.apache.zeppelin.interpreter.dev does not exist
Am I wrong with something or dev package really does not exists on branch-0.6 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1358
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by mikhaildubkov <gi...@git.apache.org>.
Github user mikhaildubkov commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@astroshim i guess it would be better just replace ZeppelinDevServer.DEFAULT_TEST_INTERPRETER_PORT by its int value for branch-0.6 to avoid necessary change for project build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@astroshim I rebuild with `mvn clean package -DskipTests -Pexamples` and it works. I should've attached `-Pexamples`. Now I can see the Helium icon :)
Anyway I checked `ArrayIndexOutOfBoundsException ` is gone with this patch. LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@astroshim Definitely in the latest master branch, I faced the below exception when I tried to run `org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer` in my IDE.
```
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 0
at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer.main(RemoteInterpreterServer.java:136)
```
Maybe that's why you created this patch.
So I tried to test this PR with below steps
1. Build again with this patch: `mvn clean package -DskipTests`
2. Restart Zeppelin: `./bin/zeppelin-daemon.sh restart`
3. Run `org.apache.zeppelin.interpreter.dev.ZeppelinApplicationDevServer` in my IntelliJ -> Successfully started
4. Run `%spark new java.util.Date` -> Nothing happened. I can't see the above Helium icons. Only Spark repl result was printed like `res0: java.util.Date = Sun Aug 28 22:31:32 KST 2016`. (I'm using `Spark 2.0`.)
Did I miss something? \u3160_\u3160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1358: [ZEPPELIN-1365] Error of Zeppelin Application in devel...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1358
@corneadoug This PR shouldn't be merged to branch-0.6. Could you revert related [commit](db7c11d3b62a8066b0138fd9700731c953cec1a5) from branch-0.6 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---