[GitHub] [rocketmq-client-cpp] lizhanhui commented on a change in pull request #384: Add 'message' into the arguments of transaction related method

[GitBox <gi...@apache.org>]

lizhanhui commented on a change in pull request #384:
URL: https://github.com/apache/rocketmq-client-cpp/pull/384#discussion_r735542776



##########
File path: src/main/cpp/rocketmq/ProducerImpl.cpp
##########
@@ -508,19 +508,19 @@ std::unique_ptr<TransactionImpl> ProducerImpl::prepare(MQMessage& message, std::
     return nullptr;
   }
 
-  return std::unique_ptr<TransactionImpl>(new TransactionImpl(
-      send_result.getMsgId(), send_result.getTransactionId(), send_result.getMessageQueue().serviceAddress(),
-      send_result.traceContext(), ProducerImpl::shared_from_this()));
+  return std::unique_ptr<TransactionImpl>(
+      new TransactionImpl(message, send_result.getTransactionId(), send_result.getMessageQueue().serviceAddress(),

Review comment:
       absl::make_unique




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org