[GitHub] [cassandra-sidecar] yifan-c commented on a diff in pull request #40: CASSANDRASC-46: Migrate minikube to testcontainers for integration tests

[GitBox <gi...@apache.org>]

yifan-c commented on code in PR #40:
URL: https://github.com/apache/cassandra-sidecar/pull/40#discussion_r996110044


##########
cassandra-integration-tests/src/test/java/org/apache/cassandra/sidecar/common/testing/TestVersionSupplier.java:
##########
@@ -28,17 +28,17 @@
  * versions of Cassandra.  This may be due to releases that don't add new features that would affect the sidecar,
  * but we still want to test those versions specifically to avoid the chance of regressions.
  *
- * At the moment, it's returning a hard coded list.  We could / should probably load this from a configuration and make
+ * <p>At the moment, it's returning a hard coded list.  We could / should probably load this from a configuration and make
  * it possible to override it, so teams that customize C* can run and test their own implementation
  *
- * Ideally, we'd probably have concurrent runs of the test infrastructure each running tests against one specific
+ * <p>Ideally, we'd probably have concurrent runs of the test infrastructure each running tests against one specific
  * version of C*, but we don't need that yet given we only have one version.
  */
 public class TestVersionSupplier
 {
     Stream<TestVersion> getTestVersions()
     {
-        return Stream.of(new TestVersion("4.0.0", new Cassandra40Factory(), "cassandra40"));
+        return Stream.of(new TestVersion("4.0.0", new Cassandra40Factory(), "cassandra:4.0.6"));

Review Comment:
   What about reading the image tag from env? The tags can become unavailable when new images are released. For example, 4.0.5 no longer exist. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org