You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Josh Tynjala <jo...@gmail.com> on 2016/12/03 00:10:55 UTC

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - SliderTrackView: ignore coercion of WrappedHTMLElement

Someone just mentioned to me that the Basic project no longer gets built,
and I guess that I need to make changes to a different project. Is it HTML
now? Maybe we should remove the Basic project code to avoid confusion, and
if anything needs to be restored later, we can find it in the history.

- Josh

On Fri, Dec 2, 2016 at 3:06 PM, <jo...@apache.org> wrote:

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop aea0364bc -> 7eef1e435
>
>
> SliderTrackView: ignore coercion of WrappedHTMLElement
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/1d39b6eb
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/1d39b6eb
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/1d39b6eb
>
> Branch: refs/heads/develop
> Commit: 1d39b6eb9c8e7ccd045cfa0f8faeb79c3a38976a
> Parents: 4e7c736
> Author: Josh Tynjala <jo...@apache.org>
> Authored: Fri Dec 2 15:05:40 2016 -0800
> Committer: Josh Tynjala <jo...@apache.org>
> Committed: Fri Dec 2 15:05:40 2016 -0800
>
> ----------------------------------------------------------------------
>  .../src/main/flex/org/apache/flex/html/beads/SliderTrackView.as     | 1 +
>  1 file changed, 1 insertion(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 1d39b6eb/frameworks/projects/Basic/src/main/flex/org/
> apache/flex/html/beads/SliderTrackView.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/SliderTrackView.as
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/beads/SliderTrackView.as
> index 4290ac7..eac9d32 100644
> --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/beads/SliderTrackView.as
> +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/
> html/beads/SliderTrackView.as
> @@ -89,6 +89,7 @@ package org.apache.flex.html.beads
>                  *  @playerversion Flash 10.2
>                  *  @playerversion AIR 2.6
>                  *  @productversion FlexJS 0.0
> +         *  @flexjsignorecoercion org.apache.flex.core.WrappedHTMLElement
>                  */
>                 override public function set strand(value:IStrand):void
>                 {
>
>

Re: [1/2] git commit: [flex-asjs] [refs/heads/develop] - SliderTrackView: ignore coercion of WrappedHTMLElement

Posted by Alex Harui <ah...@adobe.com>.

On 12/2/16, 4:10 PM, "Josh Tynjala" <jo...@gmail.com> wrote:

>Someone just mentioned to me that the Basic project no longer gets built,
>and I guess that I need to make changes to a different project. Is it HTML
>now? Maybe we should remove the Basic project code to avoid confusion, and
>if anything needs to be restored later, we can find it in the history.

I have changes locally that will build Basic.  They should be ok to push
in a day or two.  Basic is the old unwrapped Sprite code.  HTML is a copy
of it with wrapped Sprites.  Hopefully we can go back to having only one
copy soon.

I'd rather not remove Basic, but it is ok for folks to focus on HTML.  We
can sync them up later.

Thanks,
-Alex