You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2026/06/15 12:44:35 UTC
[PR] Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade [beam]
aIbrahiim opened a new pull request, #38962:
URL: https://github.com/apache/beam/pull/38962
Fixes: #35198
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38962:
URL: https://github.com/apache/beam/pull/38962#discussion_r3414364945
##########
sdks/python/build.gradle:
##########
@@ -145,12 +145,7 @@ tasks.register("yamlIntegrationTests") {
description "Runs precommit integration tests for yaml pipelines."
dependsOn installGcpTest
- // Need to build all expansion services referenced in apache_beam/yaml/*.*
- // grep -oh 'sdk.*Jar' sdks/python/apache_beam/yaml/*.yaml | sort | uniq
- dependsOn ":sdks:java:extensions:schemaio-expansion-service:shadowJar"
- dependsOn ":sdks:java:extensions:sql:expansion-service:shadowJar"
- dependsOn ":sdks:java:io:expansion-service:build"
- dependsOn ":sdks:java:io:google-cloud-platform:expansion-service:build"
+ dependsOn prepareExpansionServicesForYamlDocs
Review Comment:
Referencing the task `prepareExpansionServicesForYamlDocs` as a bare identifier can lead to configuration-time errors (such as `MissingPropertyException`) if the task is registered lazily using `tasks.register` or defined later in the build script. Using a string literal `"prepareExpansionServicesForYamlDocs"` ensures that Gradle resolves the dependency lazily and safely.
```
dependsOn "prepareExpansionServicesForYamlDocs"
```
##########
sdks/python/build.gradle:
##########
@@ -164,12 +159,7 @@ tasks.register("postCommitYamlIntegrationTests") {
description "Runs postcommit integration tests for yaml pipelines - parameterized by yamlTestSet."
dependsOn installGcpTest
- // Need to build all expansion services referenced in apache_beam/yaml/*.*
- // grep -oh 'sdk.*Jar' sdks/python/apache_beam/yaml/*.yaml | sort | uniq
- dependsOn ":sdks:java:extensions:schemaio-expansion-service:shadowJar"
- dependsOn ":sdks:java:extensions:sql:expansion-service:shadowJar"
- dependsOn ":sdks:java:io:expansion-service:build"
- dependsOn ":sdks:java:io:google-cloud-platform:expansion-service:build"
+ dependsOn prepareExpansionServicesForYamlDocs
Review Comment:
Referencing the task `prepareExpansionServicesForYamlDocs` as a bare identifier can lead to configuration-time errors (such as `MissingPropertyException`) if the task is registered lazily using `tasks.register` or defined later in the build script. Using a string literal `"prepareExpansionServicesForYamlDocs"` ensures that Gradle resolves the dependency lazily and safely.
```
dependsOn "prepareExpansionServicesForYamlDocs"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade [beam]
Posted by "Amar3tto (via GitHub)" <gi...@apache.org>.
Amar3tto closed pull request #38962: Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade
URL: https://github.com/apache/beam/pull/38962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38962:
URL: https://github.com/apache/beam/pull/38962#issuecomment-4709134396
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses compatibility issues in the PostCommit YAML Xlang Direct workflow following the migration of the IO expansion service to Java 17. By refactoring the Gradle task dependencies to use a shared preparation task, the build process now correctly handles the required expansion service artifacts, preventing failures caused by missing JAR files.
### Highlights
* **Expansion Service Compatibility**: Updated the YAML integration test tasks to use a centralized preparation task for expansion services, ensuring compatibility with the recent Java 17 upgrade.
* **Test Infrastructure**: Incremented the revision in the trigger file to ensure the PostCommit YAML Xlang Direct test suite is correctly re-run.
<details>
<summary><b>New Features</b></summary>
🧠You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Ignored Files</b></summary>
* **Ignored by pattern:** `.github/workflows/**` (1)
* .github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #38962:
URL: https://github.com/apache/beam/pull/38962#issuecomment-4710996432
> FYI #38965
Thanks, good to know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #38962:
URL: https://github.com/apache/beam/pull/38962#issuecomment-4709617335
FYI #38965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org