You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/21 12:05:55 UTC

[GitHub] [flink] Tartarus0zm opened a new pull request #12949: [FLINK-18663][rest] Fix AbstractHandler throw NPE cause by FlinkHttpObjectAggregator is null

Tartarus0zm opened a new pull request #12949:
URL: https://github.com/apache/flink/pull/12949


   ## What is the purpose of the change
   
   Fix AbstractHandler throw NPE cause by FlinkHttpObjectAggregator is null
   
   ## Brief change log
   
   if FlinkHttpObjectAggregator is null use the ```REST_SERVER_MAX_CONTENT_LENGTH_DEFAULT``` as ```maxLength```
   
   ## Verifying this change
   
   no
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #12949: [FLINK-18663][rest] Fix AbstractHandler throw NPE cause by FlinkHttpObjectAggregator is null

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12949:
URL: https://github.com/apache/flink/pull/12949#issuecomment-661817713


   I would first like to understand why the aggregator can be null (see my question on the JIRA), before going forward with any changes. Closing this PR for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol closed pull request #12949: [FLINK-18663][rest] Fix AbstractHandler throw NPE cause by FlinkHttpObjectAggregator is null

Posted by GitBox <gi...@apache.org>.
zentol closed pull request #12949:
URL: https://github.com/apache/flink/pull/12949


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12949: [FLINK-18663][rest] Fix AbstractHandler throw NPE cause by FlinkHttpObjectAggregator is null

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12949:
URL: https://github.com/apache/flink/pull/12949#issuecomment-661816700


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 5bedb0e364de614596da07aa97b73514e088b5db (Tue Jul 21 12:08:37 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18663).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org