You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2013/03/19 21:42:18 UTC
Review Request: OOZIE-1277: CoordActionInputCheck requeues itself even if
only push missing dependencies exist
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10024/
-----------------------------------------------------------
Review request for oozie.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1277
This addresses bug OOZIE-1277.
https://issues.apache.org/jira/browse/OOZIE-1277
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1458451
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1458451
Diff: https://reviews.apache.org/r/10024/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1277: CoordActionInputCheck requeues itself even
if only push missing dependencies exist
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10024/#review18108
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On March 19, 2013, 8:42 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10024/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 8:42 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1277
>
>
> This addresses bug OOZIE-1277.
> https://issues.apache.org/jira/browse/OOZIE-1277
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1458451
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1458451
>
> Diff: https://reviews.apache.org/r/10024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request: OOZIE-1277: CoordActionInputCheck requeues itself even
if only push missing dependencies exist
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10024/
-----------------------------------------------------------
(Updated March 19, 2013, 11:37 p.m.)
Review request for oozie.
Changes
-------
Addressed both of Mohammad's comments
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1277
This addresses bug OOZIE-1277.
https://issues.apache.org/jira/browse/OOZIE-1277
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1458451
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1458451
Diff: https://reviews.apache.org/r/10024/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request: OOZIE-1277: CoordActionInputCheck requeues itself even
if only push missing dependencies exist
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10024/#review18113
-----------------------------------------------------------
Ship it!
+1
Those are minor comments.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/10024/#comment38235>
can we merge this to previous "if block"?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
<https://reviews.apache.org/r/10024/#comment38236>
may be more meaning ful -->
status && ( pushDeps == null || pushDeps.length() == 0)
- Mohammad Islam
On March 19, 2013, 8:42 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10024/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 8:42 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1277
>
>
> This addresses bug OOZIE-1277.
> https://issues.apache.org/jira/browse/OOZIE-1277
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1458451
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 1458451
>
> Diff: https://reviews.apache.org/r/10024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>