You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/08/07 14:02:00 UTC
[jira] [Commented] (LUCENE-10646) Add some comment on LevenshteinAutomata
[ https://issues.apache.org/jira/browse/LUCENE-10646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576391#comment-17576391 ]
ASF subversion and git services commented on LUCENE-10646:
----------------------------------------------------------
Commit b08e34722df87e86611ba1afe42cbe7dc052f6e4 in lucene's branch refs/heads/main from tang donghai
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=b08e34722df ]
LUCENE-10646: Add some comment on LevenshteinAutomata (#1016)
* add Comment on Lev & pretty the toDot
* use auto generate scripts to add comment
* update checksum
* update checksum
* restore toDot
* add removeDeadStates in levAutomata
Co-authored-by: tangdonghai <ta...@meituan.com>
> Add some comment on LevenshteinAutomata
> ---------------------------------------
>
> Key: LUCENE-10646
> URL: https://issues.apache.org/jira/browse/LUCENE-10646
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/FSTs
> Affects Versions: 9.2
> Reporter: tang donghai
> Priority: Minor
> Time Spent: 5h
> Remaining Estimate: 0h
>
> After having a hard time reading the code, I may have understood the relevant code of levenshteinautomata, except for the part of minErrors.
> I think this part of the code is too difficult to understand, full of magic numbers. I will sort it out and then raise a PR to add some necessary comments to this part of the code. So, others can better understand this part of the code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org