[GitHub] [ozone] sodonnel commented on a diff in pull request #3891: HDDS-7402. Adapt CommandQueue to track the count of each queued command type

[GitBox <gi...@apache.org>]

sodonnel commented on code in PR #3891:
URL: https://github.com/apache/ozone/pull/3891#discussion_r1006225317


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/CommandQueue.java:
##########
@@ -38,9 +40,8 @@
  * there where queued.
  */
 public class CommandQueue {
-  // This list is used as default return value.
-  private static final List<SCMCommand> DEFAULT_LIST = new ArrayList<>();
   private final Map<UUID, Commands> commandMap;
+  private final Map<UUID, Map<SCMCommandProto.Type, Integer>> summaryMap;

Review Comment:
   I guess that is something we could do in the future if there were more things to track on a datanode by datanode basis. I'd like to avoid too much change here, and a class per DN like a DatanodeQueue would look fairly similar I think. Something like this could easily be added later if we need it, as it will be behind the CommandQueue interface, and the changes would just be internal to the class. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org