You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "weixiang1862 (via GitHub)" <gi...@apache.org> on 2023/08/30 06:21:34 UTC
[GitHub] [skywalking-swck] weixiang1862 opened a new pull request, #91: Support inject java agent bootstrap-plugins.
weixiang1862 opened a new pull request, #91:
URL: https://github.com/apache/skywalking-swck/pull/91
For https://github.com/apache/skywalking/discussions/11276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #91: Support inject java agent bootstrap-plugins.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91#issuecomment-1700470574
@dashanji Could you check the CI whether it is unstable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] weixiang1862 commented on pull request #91: Support inject java agent bootstrap-plugins.
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91#issuecomment-1698585122
> @weixiang1862 Thanks for the quick pr, could you please add an e2e test to validate the bootstrap plugins are moved into the plugins?
OK, I will add a case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] weixiang1862 commented on pull request #91: Support inject java agent bootstrap-plugins.
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91#issuecomment-1698863913
seems it is a high frequency error when run e2e, the operator not really `ready`:
```
Error from server (InternalError): error when creating "test/e2e/skywalking-components-with-swagent-configmap.yaml": Internal error occurred: failed calling webhook "mswagent.kb.io": Post "[https://skywalking-swck-webhook-service.skywalking-swck-system.svc:443/mutate-operator-skywalking-apache-org-v1alpha1-swagent?timeout=10s](https://skywalking-swck-webhook-service.skywalking-swck-system.svc/mutate-operator-skywalking-apache-org-v1alpha1-swagent?timeout=10s)": context deadline exceeded
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] dashanji merged pull request #91: Support inject java agent bootstrap-plugins.
Posted by "dashanji (via GitHub)" <gi...@apache.org>.
dashanji merged PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] dashanji commented on pull request #91: Support inject java agent bootstrap-plugins.
Posted by "dashanji (via GitHub)" <gi...@apache.org>.
dashanji commented on PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91#issuecomment-1698582006
@weixiang1862 Thanks for the quick pr, could you please add an e2e test to validate the bootstrap plugins are moved into the plugins?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] dashanji commented on pull request #91: Support inject java agent bootstrap-plugins.
Posted by "dashanji (via GitHub)" <gi...@apache.org>.
dashanji commented on PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91#issuecomment-1698937792
> seems it is a high frequency error when run e2e, the operator not really `ready`:
>
> ```
> Error from server (InternalError): error when creating "test/e2e/skywalking-components-with-swagent-configmap.yaml": Internal error occurred: failed calling webhook "mswagent.kb.io": Post "[https://skywalking-swck-webhook-service.skywalking-swck-system.svc:443/mutate-operator-skywalking-apache-org-v1alpha1-swagent?timeout=10s](https://skywalking-swck-webhook-service.skywalking-swck-system.svc/mutate-operator-skywalking-apache-org-v1alpha1-swagent?timeout=10s)": context deadline exceeded
> ```
I think you'd better to test the case locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] weixiang1862 commented on pull request #91: Support inject java agent bootstrap-plugins.
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91#issuecomment-1698770614
> @weixiang1862 Thanks for the quick pr, could you please add an e2e test to validate the bootstrap plugins are moved into the plugins?
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] weixiang1862 commented on pull request #91: Support inject java agent bootstrap-plugins.
Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91#issuecomment-1700208270
@wu-sheng @dashanji Could you please re-run the failed cases? They all passed on my local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] dashanji commented on pull request #91: Support inject java agent bootstrap-plugins.
Posted by "dashanji (via GitHub)" <gi...@apache.org>.
dashanji commented on PR #91:
URL: https://github.com/apache/skywalking-swck/pull/91#issuecomment-1700553538
> @dashanji Could you check the CI whether it is unstable?
From my experience, it's mainly caused by the resource limitation of the CI machine. we can free the unnecessary libraries to make resources for the e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org