You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Laszlo Attila Toth (Jira)" <ji...@apache.org> on 2022/02/14 09:58:00 UTC
[jira] [Comment Edited] (TEZ-4384) Remove unused EnvironmentUpdateUtils remaining from TEZ-1837
[ https://issues.apache.org/jira/browse/TEZ-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491906#comment-17491906 ]
Laszlo Attila Toth edited comment on TEZ-4384 at 2/14/22, 9:57 AM:
-------------------------------------------------------------------
[~abstractdog] It's not related to Java 17, but I found it during working on the Java 17 compatibility. The code tried to alter System.getenv directly, which doesn't work in Java 17. As I tried to figure out the intention of the code I noticed that the class has only one client, only the test class uses it.
Strangely not long after the introduction it's usage is dropped in TEZ-1837, but the actual class remained in the code base.
So I could convert it to a subclass TEZ-4373, but this is a valid bug without the Java 17 issue, too.
was (Author: JIRAUSER284468):
[~abstractdog] It's not related to Java 17, but I found it during working on the Java 17 compatibility. The code tried to alter System.getenv directly, which doesn't work in Java 17. As I tried to figure out the intention of the code I noticed that the class has only one client, only the test class uses it.
Strangely not long after the introduction it's usage is dropped in TEZ-1837, but the actual class remained in the code base.
> Remove unused EnvironmentUpdateUtils remaining from TEZ-1837
> ------------------------------------------------------------
>
> Key: TEZ-4384
> URL: https://issues.apache.org/jira/browse/TEZ-4384
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.10.1
> Reporter: Laszlo Attila Toth
> Assignee: Laszlo Attila Toth
> Priority: Major
> Fix For: 0.10.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> |EnvironmentUpdateUtils's usage was removed in TEZ-1837 in 2015, while its import and the class with the tests were kept.
> This is a dead code as of now.
>
> It's safe to delete those.|
--
This message was sent by Atlassian Jira
(v8.20.1#820001)