[GitHub] [airflow] XD-DENG commented on a change in pull request #13036: Refactor plugins command output using AirflowConsole

[GitBox <gi...@apache.org>]

XD-DENG commented on a change in pull request #13036:
URL: https://github.com/apache/airflow/pull/13036#discussion_r541783391



##########
File path: airflow/cli/commands/plugins_command.py
##########
@@ -15,17 +15,14 @@
 # specific language governing permissions and limitations
 # under the License.
 import inspect
-from typing import Any, List, Optional, Union
-
-from rich.console import Console
+from typing import Any, Dict, List, Union
 
 from airflow import plugins_manager
-from airflow.cli.simple_table import SimpleTable
-from airflow.configuration import conf
+from airflow.cli.simple_table import AirflowConsole
 from airflow.plugins_manager import PluginsDirectorySource
+from airflow.utils.cli import suppress_logs_and_warning
 
 # list to maintain the order of items.

Review comment:
       This line of comment can be removed if we confirm `PLUGINS_MANAGER_ATTRIBUTES_TO_DUMP` can be removed

##########
File path: airflow/cli/commands/plugins_command.py
##########
@@ -15,17 +15,14 @@
 # specific language governing permissions and limitations
 # under the License.
 import inspect
-from typing import Any, List, Optional, Union
-
-from rich.console import Console
+from typing import Any, Dict, List, Union
 
 from airflow import plugins_manager
-from airflow.cli.simple_table import SimpleTable
-from airflow.configuration import conf
+from airflow.cli.simple_table import AirflowConsole
 from airflow.plugins_manager import PluginsDirectorySource
+from airflow.utils.cli import suppress_logs_and_warning
 
 # list to maintain the order of items.
-from airflow.utils.cli import suppress_logs_and_warning
 
 PLUGINS_MANAGER_ATTRIBUTES_TO_DUMP = [

Review comment:
       This can be removed now I think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org