You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/01/08 01:05:35 UTC
(superset) 01/01: fix: GHA frontend builds fail when frontends hasn't changed
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch fix_frontend_builds
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 0c174695ba297ab3001faad06d0695daa4ff1790
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Jan 7 17:03:07 2025 -0800
fix: GHA frontend builds fail when frontends hasn't changed
I just merged https://github.com/apache/superset/pull/31490 and realize
it fails when no frontend changes are found. It will run the first
workflow and fail on subsequent.
This PR makes it such that the first workflow emits an output to tell
the other workflows to skip if needed.
---
.github/workflows/superset-frontend.yml | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml
index 4a67958663..2d73005fe3 100644
--- a/.github/workflows/superset-frontend.yml
+++ b/.github/workflows/superset-frontend.yml
@@ -19,6 +19,7 @@ env:
jobs:
frontend-build:
runs-on: ubuntu-24.04
+ should-run: ${{ steps.check.outputs.frontend }}
steps:
- name: Checkout Code
uses: actions/checkout@v4
@@ -57,7 +58,7 @@ jobs:
sharded-jest-tests:
needs: frontend-build
- if: needs.frontend-build.result == 'success'
+ if: needs.frontend-build.outputs.should-run == 'true'
strategy:
matrix:
shard: [1, 2, 3, 4, 5, 6, 7, 8]
@@ -89,7 +90,7 @@ jobs:
report-coverage:
needs: [sharded-jest-tests]
- if: needs.frontend-build.result == 'success'
+ if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Coverage Artifacts
@@ -115,7 +116,7 @@ jobs:
core-cover:
needs: frontend-build
- if: needs.frontend-build.result == 'success'
+ if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact
@@ -133,7 +134,7 @@ jobs:
lint-frontend:
needs: frontend-build
- if: needs.frontend-build.result == 'success'
+ if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact
@@ -156,7 +157,7 @@ jobs:
validate-frontend:
needs: frontend-build
- if: needs.frontend-build.result == 'success'
+ if: needs.frontend-build.outputs.should-run == 'true'
runs-on: ubuntu-24.04
steps:
- name: Download Docker Image Artifact