You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2020/07/23 12:00:52 UTC
[shardingsphere] branch master updated: Rename
GaugeMetricsTracker.inc and dec (#6405) (#6422)
This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 24d0709 Rename GaugeMetricsTracker.inc and dec (#6405) (#6422)
24d0709 is described below
commit 24d0709071089e8efb275fad6286098db71c3827
Author: Tboy <gu...@immomo.com>
AuthorDate: Thu Jul 23 20:00:25 2020 +0800
Rename GaugeMetricsTracker.inc and dec (#6405) (#6422)
---
.../shardingsphere/metrics/facade/handler/MetricsTrackerHandler.java | 4 ++--
.../prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java | 4 ++--
.../prometheus/impl/gauge/ChannelCountGaugeMetricsTrackerTest.java | 4 ++--
.../org/apache/shardingsphere/metrics/api/GaugeMetricsTracker.java | 4 ++--
.../apache/shardingsphere/metrics/api/GaugeMetricsTrackerTest.java | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-facade/src/main/java/org/apache/shardingsphere/metrics/facade/handler/MetricsTrackerHandler.java b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-facade/src/main/java/org/apache/shardingsphere/metrics/facade/handler/MetricsTrackerHandler.java
index 0c81ad2..f537d53 100644
--- a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-facade/src/main/java/org/apache/shardingsphere/metrics/facade/handler/MetricsTrackerHandler.java
+++ b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-facade/src/main/java/org/apache/shardingsphere/metrics/facade/handler/MetricsTrackerHandler.java
@@ -206,7 +206,7 @@ public final class MetricsTrackerHandler {
private void handlerGaugeInc(final String metricsLabel, final String... labelValues) {
metricsTrackerManager.getMetricsTrackerFactory().create(MetricsTypeEnum.GAUGE.name(), metricsLabel)
- .ifPresent(metricsTracker -> ((GaugeMetricsTracker) metricsTracker).inc(1.0, labelValues));
+ .ifPresent(metricsTracker -> ((GaugeMetricsTracker) metricsTracker).increment(1.0, labelValues));
}
/**
@@ -217,7 +217,7 @@ public final class MetricsTrackerHandler {
*/
public void handlerGaugeDec(final String metricsLabel, final String... labelValues) {
metricsTrackerManager.getMetricsTrackerFactory().create(MetricsTypeEnum.GAUGE.name(), metricsLabel)
- .ifPresent(metricsTracker -> ((GaugeMetricsTracker) metricsTracker).dec(1.0, labelValues));
+ .ifPresent(metricsTracker -> ((GaugeMetricsTracker) metricsTracker).decrement(1.0, labelValues));
}
private Optional<HistogramMetricsTrackerDelegate> handlerHistogramStartTimer(final String metricsLabel, final String... labelValues) {
diff --git a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java
index c10745e..0c1d3f0 100644
--- a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java
+++ b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java
@@ -29,12 +29,12 @@ public final class ChannelCountGaugeMetricsTracker implements GaugeMetricsTracke
private static final Gauge CHANNEL_COUNT = Gauge.build().name("channel_count").help("proxy channel count").register();
@Override
- public void inc(final double amount, final String... labelValues) {
+ public void increment(final double amount, final String... labelValues) {
CHANNEL_COUNT.inc(amount);
}
@Override
- public void dec(final double amount, final String... labelValues) {
+ public void decrement(final double amount, final String... labelValues) {
CHANNEL_COUNT.dec(amount);
}
diff --git a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-prometheus/src/test/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTrackerTest.java b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-prometheus/src/test/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTrackerTest.java
index 83a06a4..22795d7 100644
--- a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-prometheus/src/test/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTrackerTest.java
+++ b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-prometheus/src/test/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTrackerTest.java
@@ -33,10 +33,10 @@ public final class ChannelCountGaugeMetricsTrackerTest extends AbstractPrometheu
ChannelCountGaugeMetricsTracker tracker = new ChannelCountGaugeMetricsTracker();
assertThat(tracker.metricsLabel(), is(MetricsLabelEnum.CHANNEL_COUNT.getName()));
assertThat(tracker.metricsType(), is(MetricsTypeEnum.GAUGE.name()));
- tracker.inc(2.0);
+ tracker.increment(2.0);
Double inc = getCollectorRegistry().getSampleValue(name);
assertThat(inc, is(2.0));
- tracker.dec(1.0);
+ tracker.decrement(1.0);
Double dec = getCollectorRegistry().getSampleValue(name);
assertThat(dec, is(1.0));
}
diff --git a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/api/GaugeMetricsTracker.java b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/api/GaugeMetricsTracker.java
index 03bf50a..f3bb771 100644
--- a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/api/GaugeMetricsTracker.java
+++ b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/api/GaugeMetricsTracker.java
@@ -30,7 +30,7 @@ public interface GaugeMetricsTracker extends MetricsTracker {
* @param amount amount
* @param labelValues label values
*/
- void inc(double amount, String... labelValues);
+ void increment(double amount, String... labelValues);
/**
* Decrement the Gauge with label values by the given amount.
@@ -38,7 +38,7 @@ public interface GaugeMetricsTracker extends MetricsTracker {
* @param amount amount
* @param labelValues label values
*/
- void dec(double amount, String... labelValues);
+ void decrement(double amount, String... labelValues);
/**
* Metrics type.
diff --git a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-spi/src/test/java/org/apache/shardingsphere/metrics/api/GaugeMetricsTrackerTest.java b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-spi/src/test/java/org/apache/shardingsphere/metrics/api/GaugeMetricsTrackerTest.java
index 0d1c4e8..ecdc742 100644
--- a/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-spi/src/test/java/org/apache/shardingsphere/metrics/api/GaugeMetricsTrackerTest.java
+++ b/shardingsphere-control-panel/shardingsphere-metrics/shardingsphere-metrics-spi/src/test/java/org/apache/shardingsphere/metrics/api/GaugeMetricsTrackerTest.java
@@ -32,12 +32,12 @@ public final class GaugeMetricsTrackerTest implements GaugeMetricsTracker {
}
@Override
- public void inc(final double amount, final String... labelValues) {
+ public void increment(final double amount, final String... labelValues) {
}
@Override
- public void dec(final double amount, final String... labelValues) {
+ public void decrement(final double amount, final String... labelValues) {
}