[GitHub] john-bodley closed pull request #5132: Optimize presto SQL Lab query performance.

[GitBox <gi...@apache.org>]

john-bodley closed pull request #5132: Optimize presto SQL Lab query performance.
URL: https://github.com/apache/incubator-superset/pull/5132
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index cbcc570934..eb3b3681eb 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -744,6 +744,12 @@ def handle_cursor(cls, cursor, query, session):
                 break
 
             if stats:
+                state = stats.get('state')
+
+                # if already finished, then stop polling
+                if state == 'FINISHED':
+                    break
+
                 completed_splits = float(stats.get('completedSplits'))
                 total_splits = float(stats.get('totalSplits'))
                 if total_splits and completed_splits:


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org