You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2024/09/22 02:39:12 UTC

Re: [PR] [HUDI-7604] Make table name config work properly [hudi]

yihua commented on code in PR #10998:
URL: https://github.com/apache/hudi/pull/10998#discussion_r1769698468


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -964,6 +964,11 @@ object DataSourceOptionsHelper {
 
   def translateConfigurations(optParams: Map[String, String]): Map[String, String] = {
     val translatedOpt = scala.collection.mutable.Map[String, String]() ++= optParams
+    if (!translatedOpt.contains(HoodieTableConfig.NAME.key()) &&
+      translatedOpt.contains(DataSourceWriteOptions.TABLE_NAME.key())) {

Review Comment:
   Avoid using `.key()` for `contains` check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org