[jira] [Commented] (CLIMATE-484) Remove rebinning metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLIMATE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050322#comment-14050322 ] 

ASF GitHub Bot commented on CLIMATE-484:
----------------------------------------

GitHub user MJJoyce opened a pull request:

    https://github.com/apache/climate/pull/86

    CLIMATE-484 - Drop rebinning metrics

    - Drop rebinning metrics in favor of explicit rebins with the dataset processor and utils helpers prior to an evaluation run.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MJJoyce/climate CLIMATE-484

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #86
    
----
commit 9102a17cbbadca18bf46ba6039dd66fa71421ab1
Author: Michael Joyce <jo...@apache.org>
Date:   2014-07-02T16:51:11Z

    CLIMATE-484 - Remove rebinning metrics
    
    - Drop SpatialStdDevRation, TemporalPatternCorrelation,
      SeasonalSpatialStdDevRation, and SeasonalPatternCorrelation.

commit 71706a9c72e67d96d758eb17e29e3049b4cc4fd5
Author: Michael Joyce <jo...@apache.org>
Date:   2014-07-02T16:52:54Z

    CLIMATE-484 - Remove rebinning metrics from tests

----


> Remove rebinning metrics
> ------------------------
>
>                 Key: CLIMATE-484
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-484
>             Project: Apache Open Climate Workbench
>          Issue Type: Task
>          Components: metrics
>    Affects Versions: 0.3-incubating
>            Reporter: Michael Joyce
>            Assignee: Michael Joyce
>             Fix For: 0.4
>
>
> We have a few metrics (Spatial/SeasonalStdDevRatio and similar PatternCorrelation ones) that do a temporal rebin. We've discussed this before, but I think it's worth revisiting.
> In my opinion, we shouldn't be doing rebins/regrids/manipulations during an evaluation unless it's 100% necessary for the metric to make sense. In other words:
> {code}
> ds1 = ocw.local.load_file(...)
> ds2 = ocw.local.load_file(...)
> evaluation = Evaluation.evaluation(ds1, [ds2], [metrics.TemporalStdDevRatio()])
> evaluation.run()
> {code}
> Should really be:
> {code}
> ds1 = ocw.local.load_file(...)
> ds2 = ocw.local.load_file(...)
> ds1 = ocw.dataset_processor.temporal_rebin(ds1, ...)
> ds2 = ocw.dataset_processor.temporal_rebin(ds2, ...)
> evaluation = Evaluation.evaluation(ds1, [ds2], [metrics.StdDevRatio()])
> evaluation.run()
> {code}
> That is a more correct usage of the redesigned API in my opinion.
> Thoughts? Comments? I'm going to send a PR for this change, but let's discuss please.



--
This message was sent by Atlassian JIRA
(v6.2#6252)