You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by laozhp <gi...@git.apache.org> on 2016/04/04 12:34:39 UTC

[GitHub] thrift pull request: THRIFT-3774 The generated code should have ex...

GitHub user laozhp opened a pull request:

    https://github.com/apache/thrift/pull/975

    THRIFT-3774 The generated code should have exception_names meta info

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laozhp/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #975
    
----
commit 8e6d2927ab357d668182240468513e75e2273e04
Author: laozhp <la...@gmail.com>
Date:   2016-04-04T10:30:40Z

    THRIFT-3774 The generated code should have exception_names meta info

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3774 The generated code should have ex...

Posted by laozhp <gi...@git.apache.org>.
Github user laozhp commented on the pull request:

    https://github.com/apache/thrift/pull/975#issuecomment-206109970
  
    @Jens-G Thanks. I think I should do this after Jenkins's certificate fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3774 The generated code should have ex...

Posted by laozhp <gi...@git.apache.org>.
Github user laozhp commented on the pull request:

    https://github.com/apache/thrift/pull/975#issuecomment-205295462
  
    Travis CI failed with
    ```
    Broadcast message from root@testing-gce-d357df5d-d4c0-42df-9bcc-a6a7f62bb65e
    
    	(unknown) at 10:58 ...
    
    The system is going down for power off NOW!
    
    The command docker build -q -t thrift-build build/docker/debian exited with 1.
    ```
    How can I restart the check process?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3774 The generated code should have ex...

Posted by scohen <gi...@git.apache.org>.
Github user scohen commented on the pull request:

    https://github.com/apache/thrift/pull/975#issuecomment-220519010
  
    @laozhp has this been merged yet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3774 The generated code should have ex...

Posted by scohen <gi...@git.apache.org>.
Github user scohen commented on the pull request:

    https://github.com/apache/thrift/pull/975#issuecomment-220522677
  
    @laozhp I incorporated this into a namespacing fix here: https://issues.apache.org/jira/browse/THRIFT-3834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #975: THRIFT-3774 The generated code should have excepti...

Posted by laozhp <gi...@git.apache.org>.
Github user laozhp closed the pull request at:

    https://github.com/apache/thrift/pull/975


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3774 The generated code should have ex...

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/975#issuecomment-205974086
  
    > How can I restart the check process?
    
    Modify the pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #975: THRIFT-3774 The generated code should have exception_name...

Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/975
  
    @jfarrell this PR can be closed - it was merged / fixed elsewhere.  Jira ticket is closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3774 The generated code should have ex...

Posted by laozhp <gi...@git.apache.org>.
Github user laozhp commented on the pull request:

    https://github.com/apache/thrift/pull/975#issuecomment-205735083
  
    Jenkins failed with `SSL error: sslv3 alert certificate expired.`
    ```
    src/thrift/server/simple.d:143: Client died: thrift.transport.ssl.TSSLException@src/thrift/transport/ssl.d(223): SSL error: sslv3 alert certificate expired.
    ----------------
    ??:? pure @safe bool std.exception.enforce!(bool).enforce(bool, lazy object.Throwable) [0x515e16]
    ??:? void thrift.transport.ssl.TSSLSocket.checkHandshake() [0x5138d9]
    ??:? ulong thrift.transport.ssl.TSSLSocket.read(ubyte[]) [0x513457]
    ??:? ulong thrift.transport.buffered.TBufferedTransport.read(ubyte[]) [0x51c819]
    ??:? void thrift.transport.base.TBaseTransport.readAll(ubyte[]) [0x51be10]
    ??:? void thrift.transport.buffered.TBufferedTransport.readAll(ubyte[]) [0x51c9d1]
    ??:? thrift.protocol.base.TMessage thrift.protocol.binary.TBinaryProtocol!(thrift.transport.base.TTransport).TBinaryProtocol.readMessageBegin() [0x4f02ea]
    ??:? bool thrift.codegen.processor.TServiceProcessor!(async_test.AsyncTest).TServiceProcessor.process(thrift.protocol.base.TProtocol, thrift.protocol.base.TProtocol, std.variant.VariantN!(32uL).VariantN) [0x4ec275]
    ??:? void thrift.server.simple.TSimpleServer.serve(thrift.util.cancellation.TCancellation) [0x51a32b]
    ??:? void async_test.ServerThread!(thrift.server.simple.TSimpleServer).ServerThread.run() [0x4ec0fa]
    ??:? void core.thread.Thread.run() [0x54c731]
    ??:? thread_entryPoint [0x54c251]
    ??:? [0x17205181]
    Build timed out (after 480 minutes). Marking the build as failed.
    Build was aborted
    [WARNINGS] Skipping publisher since build result is FAILURE
    [TASKS] Skipping publisher since build result is FAILURE
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---