You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Xiaojian Zhou (Jira)" <ji...@apache.org> on 2020/09/02 21:31:00 UTC
[jira] [Resolved] (GEODE-8475) Resolve a potential dead lock in
ParallelGatewaySenderQueue
[ https://issues.apache.org/jira/browse/GEODE-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiaojian Zhou resolved GEODE-8475.
----------------------------------
Fix Version/s: 1.14.0
Resolution: Fixed
> Resolve a potential dead lock in ParallelGatewaySenderQueue
> ------------------------------------------------------------
>
> Key: GEODE-8475
> URL: https://issues.apache.org/jira/browse/GEODE-8475
> Project: Geode
> Issue Type: Improvement
> Reporter: Xiaojian Zhou
> Assignee: Xiaojian Zhou
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0
>
>
> When brq is created but encountered a failed GII, enqueue to it could have a potential deadlock:
> Thread-1:
> ParallelGatewaySenderQueue.put() will get a brq.getInitializationLock().readLock().lock() (lock-A’s read lock). Then during the put operation, it will try to call lockWhenRegionIsInitializing() to get failedInitialImageLock.readLock().lock (lock-B’s read lock)
> Thread-2:
> PRDS.createBucketRegion() will trigger GII but failed. So it will call cleanUpAfterFailedGII(), where it will call lockFailedInitialImageWriteLock
> () to get lock-B’s write lock first. Then call BucketRegionQueue.clearEntries().
> It will call getInitializationLock().writeLock().lock() (lock-A’s write lock).
> To fix it, we need to let thread-1 to get failedInitialImageLock.readLock() (lock-B) before requesting lock-A.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)