You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Vikas Mayur (JIRA)" <ji...@apache.org> on 2010/02/26 16:25:27 UTC
[jira] Created: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Slightly modified Visual Theme Resource Enums for better readability
--------------------------------------------------------------------
Key: OFBIZ-3519
URL: https://issues.apache.org/jira/browse/OFBIZ-3519
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Reporter: Vikas Mayur
Priority: Minor
Fix For: SVN trunk
Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
The suffix in the enum contains following changes.
1. STYLESHEET is replaced with CSS
2. JAVASCRIPT is replaced with JS
3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841335#action_12841335 ]
Scott Gray commented on OFBIZ-3519:
-----------------------------------
My guess is that it is to allow more specific ids in the future and still provide naming consistency.
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841081#action_12841081 ]
Jacques Le Roux commented on OFBIZ-3519:
----------------------------------------
I can see nothing apart this http://cwiki.apache.org/confluence/display/OFBTECH/Revisions+Requiring+Data+Migration
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841365#action_12841365 ]
Adrian Crum commented on OFBIZ-3519:
------------------------------------
Why not increase the length of the field and keep the seed data as it is?
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842970#action_12842970 ]
Jacques Le Roux commented on OFBIZ-3519:
----------------------------------------
Yes, I agree with Rishi, Scott's proposition is the better... if someone is happy to implement it. Don't forget comments above removing.
Thanks
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Rishi Solanki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842910#action_12842910 ]
Rishi Solanki commented on OFBIZ-3519:
--------------------------------------
Any conclusion?
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841332#action_12841332 ]
Jacques Le Roux commented on OFBIZ-3519:
----------------------------------------
Is it only to be able to change ids from (for instance) VT_HDR_TMPLT_LOC to VT_HEADER_TMPLT?
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841131#action_12841131 ]
Jacques Le Roux commented on OFBIZ-3519:
----------------------------------------
Sorry Vikas,
But as Scott pointed out, I don't think it's worth it...
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur updated OFBIZ-3519:
-------------------------------
Attachment: enum.patch
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841328#action_12841328 ]
Scott Gray commented on OFBIZ-3519:
-----------------------------------
I just pointed out a potential difficulty that should be taken into consideration, I never said I don't think we should proceed. This could be overcome by checking both keys during rendering and maybe we can create a theme worker class that allows the complexities to be moved away from the templates?
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842924#action_12842924 ]
Scott Gray commented on OFBIZ-3519:
-----------------------------------
Well we've had a couple of suggestions:
- Support both the new IDs and the old (me)
- Increase the field length to allow for more verbose names (Adrian)
- Do nothing (Jacques, Hans)
- Provide a migration service (Jacques)
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841322#action_12841322 ]
Anil K Patel commented on OFBIZ-3519:
-------------------------------------
This puts us in difficult spot.
In Ofbiz community code gets put in so quickly that others don't get enough time to review and sometimes feedback is does not get heard. If I don't like the piece of code then What Am I supposed to do?
I think we should be allowed to fix the issue here. In order to not break old installations, we can keep the old data and not use it.
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841325#action_12841325 ]
Hans Bakker commented on OFBIZ-3519:
------------------------------------
i completely agree, for minor readability improvement we are not going the change key seed data.
Please revert this change.
Regards,
Hans.
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841074#action_12841074 ]
Scott Gray commented on OFBIZ-3519:
-----------------------------------
Does anyone know if we have a policy for changing seed data ids? I'm guessing this change will cause problems for anyone upgrading.
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841068#action_12841068 ]
Vikas Mayur commented on OFBIZ-3519:
------------------------------------
I would like to commit this patch if no one have any objection.
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Rishi Solanki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842958#action_12842958 ]
Rishi Solanki commented on OFBIZ-3519:
--------------------------------------
+1 for Scott's suggestion, as the new ID's are giving more verbose meaning (IMO). Later we can remove the old one as dependencies resolve.
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3519) Slightly modified Visual Theme
Resource Enums for better readability
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841361#action_12841361 ]
Jacques Le Roux commented on OFBIZ-3519:
----------------------------------------
Then sorry, I don't think it's worth it. But maybe Vikas can explain more? Because Anil seems to really need this feature.
> Slightly modified Visual Theme Resource Enums for better readability
> --------------------------------------------------------------------
>
> Key: OFBIZ-3519
> URL: https://issues.apache.org/jira/browse/OFBIZ-3519
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Reporter: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: enum.patch
>
>
> Minor enhancement to the visual theme resource enumId so that a more verbose name of the resource or template file can be specified.
> The suffix STYLESHEET and JAVASCRIPT in the enum impose a restriction on specifying a meaningful name of the enumId field which is max 20 chars in size.
> The suffix in the enum contains following changes.
> 1. STYLESHEET is replaced with CSS
> 2. JAVASCRIPT is replaced with JS
> 3. LOC is completely removed from TMPLT, since it is anyway specify a template location.
> With all above points the total char size of the enum decreased and it gives an opportunity to specify better names and hence more readability.
> For example VT_HDR_TMPLT_LOC becomes VT_HEADER_TMPLT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.