[GitHub] [apr] gmbeard opened a new pull request, #40: dso: Check for NULL handle in apr_dso_sym

["gmbeard (via GitHub)" <gi...@apache.org>]

gmbeard opened a new pull request, #40:
URL: https://github.com/apache/apr/pull/40

   The voidlinux package for **apr** on musl fails the `test_unload_library` test in `testdso.c` without this `NULL` check. The test unloads the dso and then immediately tries to read a symbol from the unloaded dso, and assumes this fails. I found it was actually succeeding to read the symbol. Maybe musl's `dlsym()` function assumes you won't pass it a `NULL` handle, and this test is invoking some UB.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apr] gmbeard commented on pull request #40: dso: Check for NULL handle in apr_dso_sym

["gmbeard (via GitHub)" <gi...@apache.org>]

gmbeard commented on PR #40:
URL: https://github.com/apache/apr/pull/40#issuecomment-1517338685

   I've [discovered](https://github.com/void-linux/void-packages/pull/42972#discussion_r1171791976) that the reason this test fails is because `dlclose` is a no-op on musl, so maybe the test should be ignored on this platform instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org