You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "tomohavvk (via GitHub)" <gi...@apache.org> on 2024/04/27 08:59:41 UTC

[PR] [doc] Fix import of java-example project [avro]

tomohavvk opened a new pull request, #2875:
URL: https://github.com/apache/avro/pull/2875

   ### What is the purpose of the change
   This pull request addresses the issue concerning the importing of the `java-example` project, stemming from the error `Cannot resolve plugin org.apache.maven.plugins:maven-plugin:1.11.3`. 
   
   Upon examination, it became evident that the `org.apache.maven.plugins:maven-plugin` version utilized was sourced from `${avro.version}` variable, which is not correct. However, determining the correct version of `org.apache.maven.plugins:maven-plugin` proved elusive.
   
   Also the [getting-started-java](https://avro.apache.org/docs/1.11.1/getting-started-java/#download) tutorial have no any mentions about `org.apache.maven.plugins:maven-plugin` and i decided to fix the issue by removing the unresolved plugin `org.apache.maven.plugins:maven-plugin`. 
   
   Consequently, the project importing proceeded smoothly, and the goal `avro:schema` was able to generate the sources from the `user.avsc` file without any further impediments.
   
   ### Verifying this change
   The change is to fix import of `java-example` project
   
   ### Documentation
   Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [doc] Fix import of java-example project [avro]

Posted by "tomohavvk (via GitHub)" <gi...@apache.org>.
tomohavvk commented on PR #2875:
URL: https://github.com/apache/avro/pull/2875#issuecomment-2110747374

   @martin-g, thank you for support!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [doc] Fix import of java-example project [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2875:
URL: https://github.com/apache/avro/pull/2875#issuecomment-2109492821

   Thank you, @tomohavvk !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [doc] Fix import of java-example project [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2875:
URL: https://github.com/apache/avro/pull/2875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [doc] Fix import of java-example project [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2875:
URL: https://github.com/apache/avro/pull/2875#issuecomment-2082011701

   I have the feeling the original author really wanted to use the Avro Maven plugin (https://github.com/apache/avro/blob/f40c222c457537fb6843132c89d08d67a145daf1/lang/java/maven-plugin/pom.xml#L31)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [doc] Fix import of java-example project [avro]

Posted by "tomohavvk (via GitHub)" <gi...@apache.org>.
tomohavvk commented on PR #2875:
URL: https://github.com/apache/avro/pull/2875#issuecomment-2085122348

   @martin-g yes, you may be right. In any case, the necessary plugins are already configured in the pom.xml, and the plugin that I deleted does not affect the assembly of the `java-example` project. I removed it so that other users can successfully clone the project and play with the source generation without project importing troubles


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org