You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "TJX2014 (via GitHub)" <gi...@apache.org> on 2023/05/24 11:40:08 UTC

[GitHub] [hudi] TJX2014 opened a new pull request, #8798: Release 0.12.2 sparkside clustering groupmap

TJX2014 opened a new pull request, #8798:
URL: https://github.com/apache/hudi/pull/8798

   ### Change Logs
   Current, we can not assign a filegroup for a cluster plan.
   
   ### Impact
   We will add target filegroupId in cluster plan.
   
   ### Risk level (write none, low medium or high below)
   None
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #8798: Release 0.12.2 sparkside clustering groupmap

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8798:
URL: https://github.com/apache/hudi/pull/8798#discussion_r1230302036


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##########
@@ -211,6 +211,12 @@ public class HoodieClusteringConfig extends HoodieConfig {
       .sinceVersion("0.9.0")
       .withDocumentation("When rewriting data, preserves existing hoodie_commit_time");
 
+  public static final ConfigProperty<Boolean> GENERATE_FILE_GROUP_ADVANCE = ConfigProperty

Review Comment:
   Could you clarify why you need to assign a particular file group to a clustering group?  This defeats the purpose of clustering.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Release 0.12.2 sparkside clustering groupmap [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua closed pull request #8798: Release 0.12.2 sparkside clustering groupmap
URL: https://github.com/apache/hudi/pull/8798


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8798: Release 0.12.2 sparkside clustering groupmap

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8798:
URL: https://github.com/apache/hudi/pull/8798#issuecomment-1561025279

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bb5224f59235f395cde539b5ddb08c42ac6253f5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bb5224f59235f395cde539b5ddb08c42ac6253f5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb5224f59235f395cde539b5ddb08c42ac6253f5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Release 0.12.2 sparkside clustering groupmap [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua closed pull request #8798: Release 0.12.2 sparkside clustering groupmap
URL: https://github.com/apache/hudi/pull/8798


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org