[jira] [Commented] (SLING-5135) Whitelist legit usages of loginAdministrative and administrative ResourceResolver

["Antonio Sanso (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466512#comment-15466512 ] 

Antonio Sanso commented on SLING-5135:
--------------------------------------

[~bdelacretaz] LGTM.
One little thing. I suspect that if we enable this as is it might break some stuff.
E.g. {{org.apache.sling.resourceresolver}} has {{loginAdministrative}} calls but is not on the white list.

Do we want an extra boolean config thats says {{enableWhiteList}}  or is over killing ?

> Whitelist legit usages of loginAdministrative and administrative ResourceResolver
> ---------------------------------------------------------------------------------
>
>                 Key: SLING-5135
>                 URL: https://issues.apache.org/jira/browse/SLING-5135
>             Project: Sling
>          Issue Type: Bug
>          Components: JCR
>            Reporter: Antonio Sanso
>            Assignee: Bertrand Delacretaz
>         Attachments: SLING-5135.patch, SLING-5135.patch
>
>
> {{AbstractSlingRepositoryManager}} contains a method that disable loginAdministrative support
> {code}
>     /**
>      * Returns whether to disable the
>      * {@code SlingRepository.loginAdministrative} method or not.
>      *
>      * @return {@code true} if {@code SlingRepository.loginAdministrative} is
>      *         disabled.
>      */
>     public final boolean isDisableLoginAdministrative() 
> {code}
> This is a global configuration. It would be nice to have an extension of such mechanism that contains a white list of (few) legit usage of {{loginAdministrative}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)