You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2019/12/22 23:58:16 UTC

[cordova-windows] 01/05: update unit tests to use build tools version 15.0

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-uwp-only-test-wip0410
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit c3c8f3b5c2bf76e4659e8f1dc842753474bce015
Author: Christopher J. Brody <ch...@brody.consulting>
AuthorDate: Sun Dec 22 18:47:23 2019 -0500

    update unit tests to use build tools version 15.0
---
 spec/unit/build.spec.js | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/spec/unit/build.spec.js b/spec/unit/build.spec.js
index e18c951..e814a52 100644
--- a/spec/unit/build.spec.js
+++ b/spec/unit/build.spec.js
@@ -113,7 +113,7 @@ describe('run method', function () {
 
         // utils.isCordovaProject is a spy, so we can call andReturn directly on it
         utils.isCordovaProject.and.returnValue(false);
-        createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]);
+        createFindAllAvailableVersionsMock([{ version: '15.0', buildProject: buildSpy, path: testPath }]);
 
         return build.run([ 'node', buildPath, '--release', '--debug' ]).then(
             () => fail('Expected promise to be rejected'),
@@ -143,7 +143,7 @@ describe('run method', function () {
 
     it('should respect build configuration from \'buildConfig\' option', function () {
 
-        createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: jasmine.createSpy(), path: testPath }]);
+        createFindAllAvailableVersionsMock([{ version: '15.0', buildProject: jasmine.createSpy(), path: testPath }]);
         var buildConfigPath = path.resolve(__dirname, 'fixtures/fakeBuildConfig.json');
 
         return build.run({ buildConfig: buildConfigPath })
@@ -167,7 +167,7 @@ describe('run method', function () {
             expect(buildType).toBe('release');
         });
 
-        createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]);
+        createFindAllAvailableVersionsMock([{ version: '15.0', buildProject: buildSpy, path: testPath }]);
 
         return build.run({ release: true })
             .finally(function () {
@@ -180,7 +180,7 @@ describe('run method', function () {
             expect(buildType).toBe('debug');
         });
 
-        createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]);
+        createFindAllAvailableVersionsMock([{ version: '15.0', buildProject: buildSpy, path: testPath }]);
 
         return build.run([ 'node', buildPath ])
             .finally(function () {
@@ -193,7 +193,7 @@ describe('run method', function () {
             expect(buildArch).toBe('arm');
         });
 
-        createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]);
+        createFindAllAvailableVersionsMock([{ version: '15.0', buildProject: buildSpy, path: testPath }]);
 
         return build.run({ archs: 'arm' })
             .finally(function () {
@@ -209,7 +209,7 @@ describe('run method', function () {
 
         createFindAllAvailableVersionsMock([
             {
-                version: '14.0',
+                version: '15.0',
                 path: testPath,
                 buildProject: function (solutionFile, buildType, buildArch) {
                     expect(buildArch).toMatch(/^arm$|^any\s?cpu$|^x86$|^x64$/);
@@ -339,7 +339,7 @@ describe('run method', function () {
     });
 
     it('spec.15a should choose latest version if there are multiple versions available with minor version difference', function () {
-        var buildTools14 = { version: '14.0', buildProject: jasmine.createSpy('buildTools14'), path: testPath };
+        var buildTools14 = { version: '15.0', buildProject: jasmine.createSpy('buildTools14'), path: testPath };
         var buildTools15 = { version: '15.0', buildProject: jasmine.createSpy('buildTools15'), path: testPath };
         var buildTools151 = { version: '15.1', buildProject: jasmine.createSpy('buildTools151'), path: testPath };
 
@@ -352,7 +352,7 @@ describe('run method', function () {
     });
 
     it('spec.15b should choose latest version if there are multiple versions available with minor version difference', function () {
-        var buildTools14 = { version: '14.0', buildProject: jasmine.createSpy('buildTools14'), path: testPath };
+        var buildTools14 = { version: '15.0', buildProject: jasmine.createSpy('buildTools14'), path: testPath };
         var buildTools15 = { version: '15.0', buildProject: jasmine.createSpy('buildTools15'), path: testPath };
         var buildTools151 = { version: '15.1', buildProject: jasmine.createSpy('buildTools151'), path: testPath };
 
@@ -405,7 +405,7 @@ describe('buildFlags', function () {
         });
 
         it('should pass buildFlags directly to MSBuild', function () {
-            var buildTools = { version: '14.0', buildProject: jasmine.createSpy('buildProject').and.returnValue(Q()), path: testPath };
+            var buildTools = { version: '15.0', buildProject: jasmine.createSpy('buildProject').and.returnValue(Q()), path: testPath };
             var buildOptions = {
                 argv: ['--buildFlag', 'foo=bar']
             };


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org