Re: svn commit: r11410 - trunk/subversion/libsvn_fs_fs

[kf...@collab.net]

bliss@tigris.org writes:
> Log:
> Followup to r11364 to fix a problem pointed out by ghudson, namely
> that an empty file is not a valid revprop file.  While changing this,
> move the creation of the revprop file back up to where the svn:date
> revprop is set.
> 
> * subversion/libsvn_fs_fs/fs_fs.c
>   (svn_fs_fs__set_revision_proplist): Make it create the revprop file
>   if it does not exist.
> 
> * subversion/libsvn_fs_fs/dag.c
>   (svn_fs_fs__dag_init_fs): Use svn_fs_fs__set_revision_proplist to
>   create the revprop file for revision zero.

Minor log message nit:

The important effect here was not merely that you moved *where* the
creation of the revprop file happens, but that you changed its initial
content.  That's an important point for the summarizing paragraph, I
would think.

-Karl


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r11410 - trunk/subversion/libsvn_fs_fs

[kf...@collab.net]

Tobias Ringström <to...@ringstrom.mine.nu> writes:
> I'm not sure what you mean, because the repository was still created
> with an svn:date revprop (see svn_fs_fs__dag_init_fs). I never changed
> that. The only change I did was to create an empty revprop file in
> svn_fs_fs__write_revision_zero to make the svn_fs_fs__set_rev_prop
> call in svn_fs_fs__dag_init_fs not fail (but as ghudson pointed out, I
> created an empty file when it should have been a file with and empty
> hash). The revprop file was only empty for a few microseconds during
> the creation of the repository, but the repository was never created
> without an svn:date revprop for rev 0.

Oops, sorry.  I did test it -- I created new repositories, one of each
type, and saw no revprops on the fsfs repos, but a date prop on the
bdb repos.

Now, when I do it (at home, using a slightly different svn), they both
have dates.  I could revert back a bit and see when the behavior
changed, but it doesn't matter.  It works now, so I'm happy :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r11410 - trunk/subversion/libsvn_fs_fs

[Tobias Ringström <to...@ringstrom.mine.nu>]

kfogel@collab.net wrote:

>The important effect here was not merely that you moved *where* the
>creation of the revprop file happens, but that you changed its initial
>content.
>
I'm not sure what you mean, because the repository was still created 
with an svn:date revprop (see svn_fs_fs__dag_init_fs). I never changed 
that. The only change I did was to create an empty revprop file in 
svn_fs_fs__write_revision_zero to make the svn_fs_fs__set_rev_prop call 
in svn_fs_fs__dag_init_fs not fail (but as ghudson pointed out, I 
created an empty file when it should have been a file with and empty 
hash). The revprop file was only empty for a few microseconds during the 
creation of the repository, but the repository was never created without 
an svn:date revprop for rev 0.

/Tobias


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org