You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/21 10:57:55 UTC
[GitHub] [pulsar] lordcheng10 opened a new pull request, #17768: [cleanup][broker]remove unnecessary variable in NamespaceBundleFactory
lordcheng10 opened a new pull request, #17768:
URL: https://github.com/apache/pulsar/pull/17768
### Motivation
Variable policiesCache in NamespaceBundleFactory is not used.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #17768: [cleanup][broker]remove unnecessary variable
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #17768:
URL: https://github.com/apache/pulsar/pull/17768#issuecomment-1254766690
> Just wondering if you could run the unused variable inspection for the whole code base and make a single PR to fix that?
>
> It's possible to use Errorprone for scanning [unused variables & fields](https://errorprone.info/bugpattern/UnusedVariable). There's `errorprone` maven profile in Pulsar's maven build to enable errorprone.
OK, later I create a new PR to check all unused variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #17768: [cleanup][broker]remove unnecessary variable in NamespaceBundleFactory
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17768:
URL: https://github.com/apache/pulsar/pull/17768#issuecomment-1254481724
Just wondering if you could run the unused variable inspection for the whole code base and make a single PR to fix that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #17768: [cleanup][broker]remove unnecessary variable
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17768:
URL: https://github.com/apache/pulsar/pull/17768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org