You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "KellenSunderland (GitHub)" <gi...@apache.org> on 2018/08/27 08:01:24 UTC
[GitHub] [incubator-mxnet] KellenSunderland opened pull request
#12370: WIP: Add clang Sanitizers to CI
## Description ##
WIP: testing affects of build turning on sanitizers for all stages.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] lebeg commented on pull request #12370:
[MXNET-953] - Add ASAN sanitizer, Enable in CI
Posted by "lebeg (GitHub)" <gi...@apache.org>.
Why 7.3 is also needed?
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on pull request
#12370: [MXNET-953] - Add ASAN sanitizer, Enable in CI
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
Good spot. It's an error by the backport author. There's a dependency that is actually only available if you have both added.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland closed pull request
#12370: WIP: Add clang Sanitizers to CI
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
[ pull request closed by KellenSunderland ]
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on pull request
#12370: [MXNET-953] - Add ASAN sanitizer, Enable in CI
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
It's an error by the backport author. There's a dependency that is actually only available if you have both added.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on issue
#12370: WIP: Add clang Sanitizers to CI
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
Iterating on some tests locally.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] lebeg commented on pull request #12370:
[MXNET-953] - Add ASAN sanitizer, Enable in CI
Posted by "lebeg (GitHub)" <gi...@apache.org>.
Maybe add cmake arguments `-DCMAKE_CXX_COMPILER=/usr/bin/g++-8` `-DCMAKE_CC_COMPILER=/usr/bin/gcc-8` instead? It would be more cmake'ish.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on issue
#12370: [MXNET-953] - Add ASAN sanitizer, Enable in CI
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
Thanks Anton. I'll give it a shot.
On Mon, Sep 17, 2018, 4:41 AM Anton Chernov <no...@github.com>
wrote:
> *@lebeg* approved this pull request.
> ------------------------------
>
> In ci/docker/install/ubuntu_gcc8.sh
> <https://github.com/apache/incubator-mxnet/pull/12370#discussion_r217985488>
> :
>
> > +# regarding copyright ownership. The ASF licenses this file
> +# to you under the Apache License, Version 2.0 (the
> +# "License"); you may not use this file except in compliance
> +# with the License. You may obtain a copy of the License at
> +#
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing,
> +# software distributed under the License is distributed on an
> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +# KIND, either express or implied. See the License for the
> +# specific language governing permissions and limitations
> +# under the License.
> +
> +sudo add-apt-repository ppa:jonathonf/gcc-8.0
> +sudo add-apt-repository ppa:jonathonf/gcc-7.3
>
> Why 7.3 is also needed?
> ------------------------------
>
> In ci/docker/runtime_functions.sh
> <https://github.com/apache/incubator-mxnet/pull/12370#discussion_r217986017>
> :
>
> > @@ -336,6 +336,35 @@ build_ubuntu_cpu_cmake_debug() {
> popd
> }
>
> +build_ubuntu_cpu_cmake_asan() {
> + set -ex
> +
> + pushd .
> + cd /work/build
> + export CC="gcc-8"
>
> Maybe add cmake arguments -DCMAKE_CXX_COMPILER=/usr/bin/g++-8
> -DCMAKE_CC_COMPILER=/usr/bin/gcc-8 instead? It would be more cmake'ish.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-mxnet/pull/12370#pullrequestreview-155823187>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AHGTE7WHRyDc8YX_y7lfLYmbYKX7UISnks5ub2BBgaJpZM4WNWgi>
> .
>
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] marcoabreu closed pull request #12370:
[MXNET-953] - Add ASAN sanitizer, Enable in CI
Posted by "marcoabreu (GitHub)" <gi...@apache.org>.
[ pull request closed by marcoabreu ]
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on issue
#12370: WIP: Add ASAN sanitizer to CI
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
Collected some thoughts on ASAN here: https://cwiki.apache.org/confluence/display/MXNET/Detecting+Memory+Leaks+and+Buffer+Overflows+in+MXNet
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on issue
#12370: WIP: Add clang Sanitizers to CI
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
Iterating on some tests locally.
Note: ASAN likely requires privileged docker containers.
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-mxnet] KellenSunderland commented on issue
#12370: [MXNET-953] - Add ASAN sanitizer, Enable in CI
Posted by "KellenSunderland (GitHub)" <gi...@apache.org>.
@mxnet-label-bot can you please add [pr-awaiting-review]
[ Full content available at: https://github.com/apache/incubator-mxnet/pull/12370 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org