You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/31 17:59:33 UTC
[GitHub] [incubator-yunikorn-core] yangwwei opened a new pull request #243: [YUNIKORN-528] Nil pointer exception while receiving releasing same allocation request more than once
yangwwei opened a new pull request #243:
URL: https://github.com/apache/incubator-yunikorn-core/pull/243
the root cause is when the shim deletes a placeholder, it can trigger 2 events sometimes,
- Pod Update
- Pod Delete
When a pod updated to TERMINATED state and when a pod gets DELETED, the shim will send a release request to the core. But when there is a second release request, as the previous one already removed the allocation, then we are hitting the Nil pointer.
To fix this, we need to fix the both core and shim side to avoid NPE. This is the PR for the core side, we need to add a nil pointer check while replacing an allocation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #243: [YUNIKORN-528] Nil pointer exception while receiving releasing same allocation request more than once
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #243:
URL: https://github.com/apache/incubator-yunikorn-core/pull/243#issuecomment-770428159
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243?src=pr&el=h1) Report
> Merging [#243](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243?src=pr&el=desc) (0322fc3) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/5a1c19e280f66d6cb4fc206a675116260d6f2ff1?el=desc) (5a1c19e) will **decrease** coverage by `0.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 63.46% 63.40% -0.07%
==========================================
Files 60 60
Lines 5220 5222 +2
==========================================
- Hits 3313 3311 -2
- Misses 1747 1750 +3
- Partials 160 161 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `48.73% <0.00%> (-0.18%)` | :arrow_down: |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243/diff?src=pr&el=tree#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243?src=pr&el=footer). Last update [5a1c19e...0322fc3](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/243?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #243: [YUNIKORN-528] Nil pointer exception while receiving releasing same allocation request more than once
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #243:
URL: https://github.com/apache/incubator-yunikorn-core/pull/243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org