You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Samrat002 (via GitHub)" <gi...@apache.org> on 2026/03/26 08:57:06 UTC
[PR] [FLINK-39331] Add @Experimental annotation to public Native S3 classes [flink]
Samrat002 opened a new pull request, #27833:
URL: https://github.com/apache/flink/pull/27833
## What is the purpose of the change
Mark the public API classes in flink-s3-fs-native as experimental to signal to users that this feature is still evolving and may undergo changes in future releases.
## Brief change log
Mark following public class with `@Experimental`
1. `NativeS3FileSystemFactory`
2. `NativeS3AFileSystemFactory`
3. `NativeS3OutputStream`
4. `NativeS3RecoverableFsDataOutputStream`
5. `NativeS3Committer`
## Verifying this change
Existing UT suffices.
## Does this pull request potentially affect one of the following parts:
- Dependencies: no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes (marked as `@Experimental`)
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: no
- The S3 file system connector: yes
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39331] Add @Experimental annotation to public Native S3 classes [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27833:
URL: https://github.com/apache/flink/pull/27833#issuecomment-4132843564
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b3df798320e4cd841a5cd230755669c302e243c5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b3df798320e4cd841a5cd230755669c302e243c5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b3df798320e4cd841a5cd230755669c302e243c5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39331] Add @Experimental annotation to public Native S3 classes [flink]
Posted by "Izeren (via GitHub)" <gi...@apache.org>.
Izeren commented on code in PR #27833:
URL: https://github.com/apache/flink/pull/27833#discussion_r2993699910
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/writer/NativeS3Committer.java:
##########
@@ -39,6 +40,7 @@
* <p>The "empty parts" check is a defensive measure against programming errors - in normal
* operation, a multipart upload should always have at least one part before committing.
*/
+@Experimental
public class NativeS3Committer implements RecoverableFsDataOutputStream.Committer {
Review Comment:
Do we need this class to be public?
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/writer/NativeS3RecoverableFsDataOutputStream.java:
##########
@@ -50,6 +51,7 @@
* #closeForCommit()}, and {@link #persist()} to ensure safe cleanup of local resources without
* corrupting S3 state.
*/
+@Experimental
@NotThreadSafe
public class NativeS3RecoverableFsDataOutputStream extends RecoverableFsDataOutputStream {
Review Comment:
Same
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3OutputStream.java:
##########
@@ -42,6 +43,7 @@
* can be safely invoked from another thread (e.g. during task cancellation) per {@link
* org.apache.flink.core.fs.FSDataOutputStream} contract.
*/
+@Experimental
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39331] Add @Experimental annotation to public Native S3 classes [flink]
Posted by "Izeren (via GitHub)" <gi...@apache.org>.
Izeren commented on PR #27833:
URL: https://github.com/apache/flink/pull/27833#issuecomment-4133421853
@Samrat002, In addition, should we downgrade: `NativeS3FileSystem, NativeS3InputStream, NativeS3Recoverable, NativeS3RecoverableSerializer` to package-private or @Internal?
Also, NativeS3RecoverableWriter is marked as @PublicEvolving, and it should be @Experimental as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39331] Add @Experimental annotation to public Native S3 classes [flink]
Posted by "Samrat002 (via GitHub)" <gi...@apache.org>.
Samrat002 commented on code in PR #27833:
URL: https://github.com/apache/flink/pull/27833#discussion_r3004032822
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -33,6 +34,7 @@
import java.io.IOException;
import java.net.URI;
+@Experimental
public class NativeS3FileSystemFactory implements FileSystemFactory {
Review Comment:
added a java doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39331] Add @Experimental annotation to public Native S3 classes [flink]
Posted by "Samrat002 (via GitHub)" <gi...@apache.org>.
Samrat002 commented on PR #27833:
URL: https://github.com/apache/flink/pull/27833#issuecomment-4140557614
> @Samrat002, In addition, should we downgrade: `NativeS3FileSystem, NativeS3InputStream, NativeS3Recoverable, NativeS3RecoverableSerializer` to package-private or Internal@?
Yes . right thing to do and reduce the API visiblity . i have made the classes `NativeS3FileSystem, NativeS3InputStream, NativeS3Recoverable, NativeS3RecoverableSerializer` to package-private
> Also, NativeS3RecoverableWriter is marked as @PublicEvolving, and it should be Experimental@ as well
yes. my miss. fixed it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39331] Add @Experimental annotation to public Native S3 classes [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #27833:
URL: https://github.com/apache/flink/pull/27833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39331] Add @Experimental annotation to public Native S3 classes [flink]
Posted by "Izeren (via GitHub)" <gi...@apache.org>.
Izeren commented on code in PR #27833:
URL: https://github.com/apache/flink/pull/27833#discussion_r3002537548
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystemFactory.java:
##########
@@ -33,6 +34,7 @@
import java.io.IOException;
import java.net.URI;
+@Experimental
public class NativeS3FileSystemFactory implements FileSystemFactory {
Review Comment:
!nit, missing java doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org