You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2019/04/01 22:00:50 UTC

[incubator-pinot] branch async_broker created (now 7b5c144)

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a change to branch async_broker
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.


      at 7b5c144  Make SingleConnectionBrokerRequestHandler as default

This branch includes the following new commits:

     new 7b5c144  Make SingleConnectionBrokerRequestHandler as default

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[incubator-pinot] 01/01: Make SingleConnectionBrokerRequestHandler as default

Posted by ja...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch async_broker
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git

commit 7b5c1440e0c59ecc13f0b5d05fcc55ad1f3895a4
Author: Jackie (Xiaotian) Jiang <xa...@linkedin.com>
AuthorDate: Mon Apr 1 14:59:56 2019 -0700

    Make SingleConnectionBrokerRequestHandler as default
---
 .../org/apache/pinot/broker/broker/BrokerServerBuilder.java | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerServerBuilder.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerServerBuilder.java
index 39b25bf..387e214 100644
--- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerServerBuilder.java
+++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerServerBuilder.java
@@ -46,8 +46,9 @@ public class BrokerServerBuilder {
   public static final String METRICS_CONFIG_PREFIX = "pinot.broker.metrics";
   public static final String TABLE_LEVEL_METRICS_CONFIG = "pinot.broker.enableTableLevelMetrics";
   public static final String REQUEST_HANDLER_TYPE_CONFIG = "pinot.broker.requestHandlerType";
-  public static final String DEFAULT_REQUEST_HANDLER_TYPE = "connectionPool";
   public static final String SINGLE_CONNECTION_REQUEST_HANDLER_TYPE = "singleConnection";
+  public static final String CONNECTION_POOL_REQUEST_HANDLER_TYPE = "connectionPool";
+  public static final String DEFAULT_REQUEST_HANDLER_TYPE = SINGLE_CONNECTION_REQUEST_HANDLER_TYPE;
 
   public enum State {
     INIT, STARTING, RUNNING, SHUTTING_DOWN, SHUTDOWN
@@ -89,14 +90,14 @@ public class BrokerServerBuilder {
 
   private BrokerRequestHandler buildRequestHandler() {
     String requestHandlerType = _config.getString(REQUEST_HANDLER_TYPE_CONFIG, DEFAULT_REQUEST_HANDLER_TYPE);
-    if (requestHandlerType.equalsIgnoreCase(SINGLE_CONNECTION_REQUEST_HANDLER_TYPE)) {
-      LOGGER.info("Using SingleConnectionBrokerRequestHandler");
-      return new SingleConnectionBrokerRequestHandler(_config, _routingTable, _timeBoundaryService,
-          _accessControlFactory, _tableQueryQuotaManager, _brokerMetrics);
-    } else {
+    if (requestHandlerType.equalsIgnoreCase(CONNECTION_POOL_REQUEST_HANDLER_TYPE)) {
       LOGGER.info("Using ConnectionPoolBrokerRequestHandler");
       return new ConnectionPoolBrokerRequestHandler(_config, _routingTable, _timeBoundaryService, _accessControlFactory,
           _tableQueryQuotaManager, _brokerMetrics, _liveInstanceChangeHandler, _metricsRegistry);
+    } else {
+      LOGGER.info("Using SingleConnectionBrokerRequestHandler");
+      return new SingleConnectionBrokerRequestHandler(_config, _routingTable, _timeBoundaryService,
+          _accessControlFactory, _tableQueryQuotaManager, _brokerMetrics);
     }
   }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org