You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zoltar9264 (via GitHub)" <gi...@apache.org> on 2024/04/24 04:25:06 UTC

[PR] [hotfix] make sure run RecordContext#release() in Task thread. [flink]

zoltar9264 opened a new pull request, #24705:
URL: https://github.com/apache/flink/pull/24705

   ## What is the purpose of the change
   
   This is a internal hotfix within development of async state execution (see: FLIP-425).
   
   ## Brief change log
   
     - add a ReleaseHelper parameter to ReferenceCounted
     - RecordContext use disposer runner as release helper, when ref-count reach 0, it will be used run disposer
     - add a 'inCallbackRunner' parameter to StateFutureImpl#postComplete()
     - ContextStateFutureImpl#postComplete() pass director runner or callbackRunner to RecordContext#release() depends on 'inCallbackRunner'
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): yes
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] make sure run RecordContext#release() in Task thread. [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24705:
URL: https://github.com/apache/flink/pull/24705#issuecomment-2074004826

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "728b394e79f0d7d1fb54b2ac9287371fb8297397",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "728b394e79f0d7d1fb54b2ac9287371fb8297397",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 728b394e79f0d7d1fb54b2ac9287371fb8297397 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] make sure run RecordContext#release() in Task thread. [flink]

Posted by "fredia (via GitHub)" <gi...@apache.org>.
fredia merged PR #24705:
URL: https://github.com/apache/flink/pull/24705


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] make sure run RecordContext#release() in Task thread. [flink]

Posted by "fredia (via GitHub)" <gi...@apache.org>.
fredia commented on PR #24705:
URL: https://github.com/apache/flink/pull/24705#issuecomment-2076765458

   Thanks for the PR, LGTM. How about updating the commit msg to "[hotfix][runtime] Make sure run RecordContext#release() in Task thread." ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] make sure run RecordContext#release() in Task thread. [flink]

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #24705:
URL: https://github.com/apache/flink/pull/24705#issuecomment-2074004272

   Hi @Zakelly , can you help me review this pr ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] make sure run RecordContext#release() in Task thread. [flink]

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #24705:
URL: https://github.com/apache/flink/pull/24705#issuecomment-2076289229

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] make sure run RecordContext#release() in Task thread. [flink]

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #24705:
URL: https://github.com/apache/flink/pull/24705#issuecomment-2076288986

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] make sure run RecordContext#release() in Task thread. [flink]

Posted by "zoltar9264 (via GitHub)" <gi...@apache.org>.
zoltar9264 commented on PR #24705:
URL: https://github.com/apache/flink/pull/24705#issuecomment-2074350219

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org