You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2024/03/04 08:35:59 UTC
[PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
yiguolei opened a new pull request, #31734:
URL: https://github.com/apache/doris/pull/31734
## Proposed changes
TaskWorkerPool Thread name is too long, and could not display it in top -H or io top, it should be more simple.
<img width="855" alt="image" src="https://github.com/apache/doris/assets/9208457/07223ddd-af80-468b-9227-b8761d14ee96">
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976841370
<details>
<summary>TPC-DS: <b>Total hot run time: 178128 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4f8a84573486c4b6e595fcb21b7158b4117c17a3, data reload: false
query1 924 357 332 332
query2 7323 2115 2006 2006
query3 6715 220 213 213
query4 26012 21169 21211 21169
query5 4312 4965 554 554
query6 281 179 187 179
query7 4632 300 312 300
query8 231 179 166 166
query9 8391 2170 2181 2170
query10 425 241 243 241
query11 14825 14321 14099 14099
query12 128 88 89 88
query13 1643 427 428 427
query14 9047 6890 7334 6890
query15 226 194 191 191
query16 7254 279 279 279
query17 952 591 578 578
query18 1931 304 288 288
query19 220 163 163 163
query20 96 88 92 88
query21 204 127 125 125
query22 4575 4535 4527 4527
query23 31555 30879 30792 30792
query24 11907 3080 3051 3051
query25 704 404 401 401
query26 1933 174 164 164
query27 2930 357 362 357
query28 6674 1826 1818 1818
query29 1336 627 611 611
query30 312 153 150 150
query31 930 731 757 731
query32 101 61 61 61
query33 767 271 256 256
query34 965 454 476 454
query35 918 806 812 806
query36 940 800 803 800
query37 274 71 71 71
query38 3191 3148 3108 3108
query39 1384 1362 1362 1362
query40 297 117 114 114
query41 54 53 51 51
query42 111 110 104 104
query43 440 410 397 397
query44 1066 727 715 715
query45 207 193 192 192
query46 1056 793 769 769
query47 1609 1554 1555 1554
query48 418 359 342 342
query49 1182 339 325 325
query50 775 380 373 373
query51 6667 6612 6565 6565
query52 108 94 88 88
query53 345 281 284 281
query54 315 241 233 233
query55 84 91 89 89
query56 241 237 217 217
query57 1085 998 989 989
query58 253 226 232 226
query59 2400 2314 2254 2254
query60 276 244 279 244
query61 102 118 97 97
query62 648 409 413 409
query63 300 278 288 278
query64 6251 3182 3172 3172
query65 3027 3013 3032 3013
query66 1475 342 346 342
query67 15270 14566 14504 14504
query68 9322 579 604 579
query69 648 413 396 396
query70 1206 1108 1117 1108
query71 578 286 300 286
query72 8872 2793 2641 2641
query73 805 344 346 344
query74 7256 6880 6823 6823
query75 4820 2722 2662 2662
query76 6185 1042 1176 1042
query77 921 268 268 268
query78 10273 9575 9515 9515
query79 10865 525 534 525
query80 1279 397 407 397
query81 490 209 207 207
query82 745 91 91 91
query83 196 147 146 146
query84 287 82 84 82
query85 1530 377 326 326
query86 448 303 281 281
query87 3377 3176 3148 3148
query88 4239 2371 2364 2364
query89 536 354 367 354
query90 2113 176 187 176
query91 158 131 129 129
query92 58 50 51 50
query93 7123 533 509 509
query94 1317 186 190 186
query95 461 358 360 358
query96 602 272 271 271
query97 3986 3921 3913 3913
query98 223 225 203 203
query99 1194 785 745 745
Total cold run time: 305343 ms
Total hot run time: 178128 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31734:
URL: https://github.com/apache/doris/pull/31734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976028475
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976852982
<details>
<summary>ClickBench: <b>Total hot run time: 31.11 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4f8a84573486c4b6e595fcb21b7158b4117c17a3, data reload: false
query1 0.04 0.04 0.03
query2 0.06 0.03 0.03
query3 0.24 0.06 0.05
query4 1.68 0.10 0.10
query5 0.52 0.49 0.49
query6 1.29 0.66 0.66
query7 0.02 0.02 0.01
query8 0.04 0.02 0.02
query9 0.56 0.51 0.53
query10 0.57 0.56 0.57
query11 0.14 0.10 0.10
query12 0.13 0.10 0.10
query13 0.58 0.56 0.56
query14 0.72 0.76 0.74
query15 0.82 0.81 0.81
query16 0.37 0.38 0.37
query17 1.03 0.97 0.97
query18 0.27 0.26 0.27
query19 1.82 1.68 1.74
query20 0.02 0.01 0.02
query21 15.41 0.62 0.63
query22 2.78 3.16 2.73
query23 17.26 1.05 1.03
query24 2.10 0.40 0.18
query25 0.31 0.07 0.05
query26 0.17 0.14 0.14
query27 0.04 0.03 0.03
query28 12.53 0.84 0.82
query29 12.57 3.29 3.53
query30 0.62 0.53 0.58
query31 2.80 0.34 0.35
query32 3.39 0.44 0.43
query33 2.91 2.92 2.91
query34 15.46 4.34 4.31
query35 4.33 4.33 4.35
query36 1.08 1.02 1.02
query37 0.06 0.06 0.06
query38 0.04 0.03 0.04
query39 0.02 0.01 0.02
query40 0.15 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.02
Total cold run time: 105.09 s
Total hot run time: 31.11 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976009392
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976859711
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 4f8a84573486c4b6e595fcb21b7158b4117c17a3 with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 18.4 seconds inserted 10000000 Rows, about 543K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976184860
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976184957
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976752374
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [enhancement](threadname) change thread name more simple in order to see it in top -H [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31734:
URL: https://github.com/apache/doris/pull/31734#issuecomment-1976816397
<details>
<summary>TPC-H: <b>Total hot run time: 37982 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4f8a84573486c4b6e595fcb21b7158b4117c17a3, data reload: false
------ Round 1 ----------------------------------
q1 18811 4194 4077 4077
q2 2021 153 147 147
q3 10557 943 940 940
q4 4662 929 937 929
q5 7606 2886 3013 2886
q6 180 125 124 124
q7 1287 841 812 812
q8 9489 2105 2097 2097
q9 7344 6506 6437 6437
q10 8199 2564 2522 2522
q11 437 214 233 214
q12 754 314 313 313
q13 17959 2915 2942 2915
q14 284 243 245 243
q15 502 451 439 439
q16 486 394 395 394
q17 945 903 832 832
q18 6612 5883 5951 5883
q19 1572 1532 1523 1523
q20 537 287 269 269
q21 7599 3661 3701 3661
q22 785 326 325 325
Total cold run time: 108628 ms
Total hot run time: 37982 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4015 4010 3998 3998
q2 323 231 232 231
q3 2984 2889 2914 2889
q4 1853 1836 1825 1825
q5 5250 5243 5239 5239
q6 206 118 116 116
q7 2268 1867 1838 1838
q8 3216 3292 3302 3292
q9 8582 8576 8619 8576
q10 6265 3745 3733 3733
q11 527 445 422 422
q12 696 530 555 530
q13 4953 2868 2844 2844
q14 277 253 261 253
q15 480 435 437 435
q16 450 421 417 417
q17 1686 1655 1661 1655
q18 7775 7584 7403 7403
q19 1738 1609 1606 1606
q20 1943 1709 1768 1709
q21 4964 4863 4770 4770
q22 539 444 472 444
Total cold run time: 60990 ms
Total hot run time: 54225 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org